-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: E2E test on endpoint versions only #10441
Conversation
A couple test cases are failing on unrelated issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://devguide.python.org/versions/, Python 3.7 is EOL from 2023-06-27. I suggest to turn off 3.7 testing completely and keep testing on 3.8 and 3.11 by default. I think it should be agreed with the language team before proceeding.
Updated to 3.8 & 3.11 based on feedback. Python team can review and provide feedback before merging. Thanks! |
It might require some changes to how we run the tests, but would it be now then better to change |
@dandhlee I like your proposal. How do you feel about approaching it in 2 steps?
We can then verify each step independently, including ensuring that step 2 tests the same versions as 1. Step 2 may also have some edge cases that we haven't thought about yet. I am open either way though, if you feel we should combine those in this PR. Thanks! |
@rsamborski - I should update this PR to remove 3.7 references after we merge #10453? IIUC, they should just be noise now, since 3.7 won't be tested. |
Feel free to leave 3.7 as is (noise). We can remove it together with noxfile config refactoring (step 2 from your list above). |
…docs-samples into test-endpoints
Approvals in place. A couple tests failed due to unrelated issues. Admin-merging. |
To reduce testing overhead and costs, update default test matrix to endpoints. Currently these are 3.7 and 3.11, but since Python 3.7 is EOL on 6/27/2003, these endpoints have been set to 3.8 and 3.11.
This ensures that dependency conflicts are detected. The earliest and latest versions are checked.
Samples with non-standard test configurations are not affected by this change.