Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Ran nox -s blacken on samples #10231

Merged
merged 6 commits into from
Jun 15, 2023
Merged

chore: Ran nox -s blacken on samples #10231

merged 6 commits into from
Jun 15, 2023

Conversation

holtskinner
Copy link
Contributor

@holtskinner holtskinner requested a review from a team June 13, 2023 15:16
@holtskinner holtskinner added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 13, 2023
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 13, 2023
@holtskinner holtskinner changed the title chore: Ran nox -s format with Google isort profile chore: Ran nox -s blacken on samples Jun 13, 2023
@holtskinner holtskinner added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 13, 2023
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 13, 2023
@kamalaboulhosn kamalaboulhosn removed their assignment Jun 13, 2023
@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 13, 2023
@holtskinner holtskinner added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 14, 2023
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 14, 2023
This was referenced Jun 14, 2023
Closed
Closed
Closed
Closed
Closed
@holtskinner
Copy link
Contributor Author

Issues filed for flaky tests:

@kweinmeister
Copy link
Contributor

There are only unrelated test failures, which @holtskinner has created issues for. Lint, Owlbot, and all other checks are passing. Admin merging.

@leahecole
Copy link
Collaborator

I marked a few of these as resolved because they were duplicates of known issues - I linked to the known issues in the ones Holt opened!

@leahecole leahecole merged commit 9b7c9ac into main Jun 15, 2023
@leahecole leahecole deleted the formatting branch June 15, 2023 14:38
@leahecole
Copy link
Collaborator

admin merging for Karl after talking to him on chat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kweinmeister kweinmeister kweinmeister approved these changes

@davidcavazos davidcavazos davidcavazos approved these changes

@leahecole leahecole Awaiting requested review from leahecole

@bradmiro bradmiro Awaiting requested review from bradmiro

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe chalmerlowe is a code owner

@ymotongpoo ymotongpoo Awaiting requested review from ymotongpoo

@yuriatgoogle yuriatgoogle Awaiting requested review from yuriatgoogle

@justin-mp justin-mp Awaiting requested review from justin-mp

Assignees
No one assigned
Labels
api: appengine Issues related to the App Engine Admin API API. api: datastore Issues related to the Datastore API. api: pubsub Issues related to the Pub/Sub API. api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. snippet-bot:no-prefix-req Instruct snippet-bot to ignore prefix requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@holtskinner @kweinmeister @leahecole @davidcavazos @kamalaboulhosn @kokoro-team