Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate code from googleapis/python-video-live-stream #10200

Merged
merged 55 commits into from
Sep 15, 2023

Conversation

parthea
Copy link
Collaborator

@parthea parthea commented Jun 8, 2023

Description

Towards googleapis/google-cloud-python#10966

Note: based on guidelines in dee-lang-mono-repos, use Rebase & Merge to preserve the commit history

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 8, 2023
@kweinmeister kweinmeister added the snippet-bot:force-run Force snippet-bot runs its logic label Jun 13, 2023
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jun 13, 2023
@snippet-bot
Copy link

snippet-bot bot commented Jun 13, 2023

Here is the summary of changes.

You are about to add 23 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kweinmeister
Copy link
Contributor

@parthea this is passing all tests; anything else needed?

@dizcology dizcology force-pushed the python-video-live-stream-migration branch from 6312c5c to 4b311d9 Compare September 11, 2023 22:44
@dizcology
Copy link
Member

Still need to update CODEOWNERS and blunderbuss. I will do this after #10605

irataxy and others added 22 commits September 15, 2023 10:38
* docs(samples): add code samples

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix region tags

* enforce Python type hints

* use build specific projects for samples testing

* Remove project number env variable. Remove cloud storage dependency. Clean up resources > 3 hours old (instead of 2 days old).

* Remove project number in favor of project ID. Avoid infinite loops in responses to LROs.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* Try to stop channel again before deleting it in the test.

* docs(samples): try to stop channel again before deleting it in the test.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(deps): update dependency google-api-python-client to v2.47.0

* chore: remove dependency google-api-python-client in samples

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
skipping optional check for kokoro pre-release dependencies.
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
…utes (#82)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore(deps): update all dependencies to v1.0.1

* revert

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
renovate-bot and others added 10 commits September 15, 2023 10:38
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* docs(samples): add samples and tests for pools and assets

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
@dizcology dizcology force-pushed the python-video-live-stream-migration branch from 6e75d0f to 05b57e2 Compare September 15, 2023 17:38
@dizcology dizcology marked this pull request as ready for review September 15, 2023 18:42
@dizcology dizcology requested review from a team as code owners September 15, 2023 18:42
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

video/live-stream/noxfile_config.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to check for this 🤪

video/live-stream/README.md Outdated Show resolved Hide resolved
video/live-stream/README.md Outdated Show resolved Hide resolved
dizcology and others added 2 commits September 15, 2023 13:01
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
@dizcology
Copy link
Member

Thanks for catching this! Doing a quick search for "googleapis/python-" turns up several other README files, by the way.

@dandhlee
Copy link
Collaborator

Perhaps we missed a few. I'll file an issue to help clean those up - thank you!

Admin merging this PR for sample migration.

@dandhlee dandhlee merged commit ce5e0fb into main Sep 15, 2023
4 checks passed
@dandhlee dandhlee deleted the python-video-live-stream-migration branch September 15, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants