Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch.tests.test_basics: test_container_job failed #9211

Closed
flaky-bot bot opened this issue Mar 3, 2023 · 4 comments
Closed

batch.tests.test_basics: test_container_job failed #9211

flaky-bot bot opened this issue Mar 3, 2023 · 4 comments
Assignees
Labels
api: batch Issues related to the Batch API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Mar 3, 2023

Note: #8899 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: c13058d
buildURL: Build Status, Sponge
status: failed

Test output
Traceback (most recent call last):
  File "/workspace/batch/tests/test_basics.py", line 100, in test_container_job
    _test_body(job, additional_test=lambda: _check_tasks(job_name))
  File "/workspace/batch/tests/test_basics.py", line 56, in _test_body
    pytest.fail("Timed out while waiting for job to complete!")
  File "/workspace/batch/.nox/py-3-11/lib/python3.11/site-packages/_pytest/outcomes.py", line 194, in fail
    raise Failed(msg=reason, pytrace=pytrace)
Failed: Timed out while waiting for job to complete!
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 3, 2023
@product-auto-label product-auto-label bot added api: batch Issues related to the Batch API. samples Issues that are directly related to samples. labels Mar 3, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Mar 4, 2023

Test passed for commit 3e28b78 (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Mar 4, 2023
@flaky-bot flaky-bot bot reopened this Mar 8, 2023
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Mar 8, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Mar 8, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


commit: c99c9c0
buildURL: Build Status, Sponge
status: failed

Test output
Traceback (most recent call last):
  File "/workspace/batch/.nox/py-3-9/lib/python3.9/site-packages/google/api_core/retry.py", line 191, in retry_target
    return target()
  File "/workspace/batch/.nox/py-3-9/lib/python3.9/site-packages/google/api_core/future/polling.py", line 120, in _done_or_raise
    raise _OperationNotComplete()
google.api_core.future.polling._OperationNotComplete

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
File "/workspace/batch/.nox/py-3-9/lib/python3.9/site-packages/google/api_core/future/polling.py", line 137, in _blocking_poll
polling(self._done_or_raise)(retry=retry)
File "/workspace/batch/.nox/py-3-9/lib/python3.9/site-packages/google/api_core/retry.py", line 349, in retry_wrapped_func
return retry_target(
File "/workspace/batch/.nox/py-3-9/lib/python3.9/site-packages/google/api_core/retry.py", line 207, in retry_target
raise exceptions.RetryError(
google.api_core.exceptions.RetryError: Deadline of 900.0s exceeded while calling target function, last exception:

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/workspace/batch/tests/test_basics.py", line 100, in test_container_job
_test_body(job, additional_test=lambda: _check_tasks(job_name))
File "/workspace/batch/tests/test_basics.py", line 71, in _test_body
delete_job(PROJECT, REGION, test_job.name.rsplit('/', maxsplit=1)[1]).result()
File "/workspace/batch/.nox/py-3-9/lib/python3.9/site-packages/google/api_core/future/polling.py", line 256, in result
self._blocking_poll(timeout=timeout, retry=retry, polling=polling)
File "/workspace/batch/.nox/py-3-9/lib/python3.9/site-packages/google/api_core/future/polling.py", line 139, in _blocking_poll
raise concurrent.futures.TimeoutError(
concurrent.futures._base.TimeoutError: Operation did not complete within the designated timeout of 900 seconds.

@atulep
Copy link

atulep commented Mar 20, 2023

@m-strzelczyk PTAL

Looks like the issue happens sometimes when delete_job takes more than the default value of 900 seconds to complete.

To fix, I suggest:

delete_job(PROJECT, REGION, test_job.name.rsplit('/', maxsplit=1)[1]).result(timeout=23*60*60) # or some other default value.

@flaky-bot flaky-bot bot reopened this Mar 28, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Mar 28, 2023

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: 3883f8f
buildURL: Build Status, Sponge
status: failed

Test output
Traceback (most recent call last):
  File "/workspace/batch/tests/test_basics.py", line 100, in test_container_job
    _test_body(job, additional_test=lambda: _check_tasks(job_name))
  File "/workspace/batch/tests/test_basics.py", line 56, in _test_body
    pytest.fail("Timed out while waiting for job to complete!")
  File "/workspace/batch/.nox/py-3-11/lib/python3.11/site-packages/_pytest/outcomes.py", line 194, in fail
    raise Failed(msg=reason, pytrace=pytrace)
Failed: Timed out while waiting for job to complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: batch Issues related to the Batch API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants