Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old Cloud SQL region tags once docs have been updated #8253

Open
jackwotherspoon opened this issue Aug 10, 2022 · 2 comments
Open

Remove old Cloud SQL region tags once docs have been updated #8253

jackwotherspoon opened this issue Aug 10, 2022 · 2 comments
Assignees
@jackwotherspoon
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@jackwotherspoon
Copy link
Contributor

As part of #8250 we are adding new region tags for consistency across languages.

Removal of old cloud_sql_XXX_sqlalchemy_sslcerts region tags from samples will be required once docs have been updated to use new region tag.

Affected files to be updated:
https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/cloud-sql/postgres/sqlalchemy/connect_tcp.py
https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/cloud-sql/mysql/sqlalchemy/connect_tcp.py
https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/cloud-sql/sql-server/sqlalchemy/connect_tcp.py
@jackwotherspoon jackwotherspoon added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Aug 10, 2022
@jackwotherspoon jackwotherspoon self-assigned this Aug 10, 2022
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 10, 2022
@bugalwena
Copy link

Thanks, I will

@jackwotherspoon
Copy link
Contributor Author

@bugalwena the tags cannot be removed yet. They can only be removed once the docs have been updated accordingly to use the new tags for code samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwotherspoon jackwotherspoon

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackwotherspoon @bugalwena