Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appgengine fusion tests failing #2556

Closed
leahecole opened this issue Nov 19, 2019 · 1 comment · Fixed by #2558
Closed

appgengine fusion tests failing #2556

leahecole opened this issue Nov 19, 2019 · 1 comment · Fixed by #2558
Assignees
@crwilcox
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. testing

Comments

@leahecole
Copy link
Collaborator

leahecole commented Nov 19, 2019 •
edited
Loading

Hey! It seems like this PR #2428 broke the appengine fusion tests awhile ago - it's having trouble finding that version of pytest for the python 2 tests. Given the sunset of Python 2, do you have opinions on how best to resolve this? Feel free to set up time with me if you want to look at this together.
@leahecole leahecole added testing priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Nov 19, 2019
@leahecole leahecole assigned leahecole and crwilcox and unassigned leahecole Nov 19, 2019
@leahecole leahecole mentioned this issue Nov 19, 2019
Closed
@crwilcox crwilcox mentioned this issue Nov 19, 2019
Merged
@crwilcox
Copy link
Contributor

Good catch. Digging into this we may need to pin pytest to < 5.0.0dev as at 5.0 they started requiring >= 3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crwilcox crwilcox

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. testing
Projects
None yet
Milestone
No milestone
2 participants
@crwilcox @leahecole