Skip to content

Commit 687a1e1

Browse files
authored
fix: longer waits to reduce flaky (#8288)
1 parent 15ab3cb commit 687a1e1

File tree

6 files changed

+23
-23
lines changed

6 files changed

+23
-23
lines changed

appengine/standard_python3/bundled-services/deferred/django/main.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ def increment_counter(request):
4141
deferred.defer(do_something_later, my_key, 10)
4242

4343
# Use default URL and queue name, no task name, execute after 10s.
44-
deferred.defer(do_something_later, my_key, 10, _countdown=10)
44+
deferred.defer(do_something_later, my_key, 10, _countdown=20)
4545

4646
# Providing non-default task queue arguments
47-
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=20)
47+
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=40)
4848

4949
return HttpResponse("Deferred counter increment.")
5050

appengine/standard_python3/bundled-services/deferred/django/main_test.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -82,19 +82,19 @@ def test_upload_and_view(version):
8282
assert response.status_code == 200
8383

8484
# counter should be 10 almost immediately
85-
time.sleep(5)
85+
time.sleep(10)
8686
response = requests.get(f"https://{version_hostname}/counter/get")
8787
assert response.status_code == 200
8888
assert response.text == "10"
8989

90-
# After 10 seconds, counter should be 20
91-
time.sleep(10)
90+
# After 20 seconds, counter should be 20
91+
time.sleep(20)
9292
response = requests.get(f"https://{version_hostname}/counter/get")
9393
assert response.status_code == 200
9494
assert response.text == "20"
9595

96-
# After 20 seconds, counter should be 30
97-
time.sleep(10)
96+
# After 40 seconds, counter should be 30
97+
time.sleep(20)
9898
response = requests.get(f"https://{version_hostname}/counter/get")
9999
assert response.status_code == 200
100100
assert response.text == "30"

appengine/standard_python3/bundled-services/deferred/flask/main.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ def increment_counter():
4242
deferred.defer(do_something_later, my_key, 10)
4343

4444
# Use default URL and queue name, no task name, execute after 10s.
45-
deferred.defer(do_something_later, my_key, 10, _countdown=10)
45+
deferred.defer(do_something_later, my_key, 10, _countdown=20)
4646

4747
# Providing non-default task queue arguments
48-
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=20)
48+
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=40)
4949

5050
return "Deferred counter increment."
5151

appengine/standard_python3/bundled-services/deferred/flask/main_test.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -81,20 +81,20 @@ def test_upload_and_view(version):
8181
response = requests.get(f"https://{version_hostname}/counter/increment")
8282
assert response.status_code == 200
8383

84-
# counter should be 10 almost immediately
85-
time.sleep(5)
84+
# counter should be 10 almost immediately. ALMOST immediately
85+
time.sleep(10)
8686
response = requests.get(f"https://{version_hostname}/counter/get")
8787
assert response.status_code == 200
8888
assert response.text == "10"
8989

90-
# After 10 seconds, counter should be 20
91-
time.sleep(10)
90+
# After 20 seconds, counter should be 20
91+
time.sleep(20)
9292
response = requests.get(f"https://{version_hostname}/counter/get")
9393
assert response.status_code == 200
9494
assert response.text == "20"
9595

96-
# After 20 seconds, counter should be 30
97-
time.sleep(10)
96+
# After 40 seconds, counter should be 30
97+
time.sleep(20)
9898
response = requests.get(f"https://{version_hostname}/counter/get")
9999
assert response.status_code == 200
100100
assert response.text == "30"

appengine/standard_python3/bundled-services/deferred/wsgi/main.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ def IncrementCounter(environ, start_response):
3838
deferred.defer(do_something_later, my_key, 10)
3939

4040
# Use default URL and queue name, no task name, execute after 10s.
41-
deferred.defer(do_something_later, my_key, 10, _countdown=10)
41+
deferred.defer(do_something_later, my_key, 10, _countdown=20)
4242

4343
# Providing non-default task queue arguments
44-
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=20)
44+
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=40)
4545

4646
start_response("200 OK", [("Content-Type", "text/html")])
4747
return ["Deferred counter increment.".encode("utf-8")]

appengine/standard_python3/bundled-services/deferred/wsgi/main_test.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -81,20 +81,20 @@ def test_upload_and_view(version):
8181
response = requests.get(f"https://{version_hostname}/counter/increment")
8282
assert response.status_code == 200
8383

84-
# counter should be 10 almost immediately
85-
time.sleep(5)
84+
# counter should be 10 almost immediately. ALMOST immediately
85+
time.sleep(10)
8686
response = requests.get(f"https://{version_hostname}/counter/get")
8787
assert response.status_code == 200
8888
assert response.text == "10"
8989

90-
# After 10 seconds, counter should be 20
91-
time.sleep(10)
90+
# After 20 seconds, counter should be 20
91+
time.sleep(20)
9292
response = requests.get(f"https://{version_hostname}/counter/get")
9393
assert response.status_code == 200
9494
assert response.text == "20"
9595

96-
# After 20 seconds, counter should be 30
97-
time.sleep(10)
96+
# After 40 seconds, counter should be 30
97+
time.sleep(20)
9898
response = requests.get(f"https://{version_hostname}/counter/get")
9999
assert response.status_code == 200
100100
assert response.text == "30"

0 commit comments

Comments
 (0)