Skip to content

Commit 22e4af1

Browse files
test: clean up extra topics from snippet tests (#324)
* added code to remove extra topics in snippet tests * fixed lint issue
1 parent 3aa3713 commit 22e4af1

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

logging/samples/snippets/usage_guide.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,13 +264,19 @@ def _sink_pubsub_setup(client):
264264
) # API call
265265
# [END sink_topic_permissions]
266266

267-
return topic
267+
# create callback wrapper to delete topic when done
268+
class TopicDeleter:
269+
def delete(self):
270+
client.delete_topic(request={"topic": topic_path})
271+
272+
return topic, TopicDeleter()
268273

269274

270275
@snippet
271276
def sink_pubsub(client, to_delete):
272277
"""Sink log entries to pubsub."""
273-
topic = _sink_pubsub_setup(client)
278+
topic, topic_deleter = _sink_pubsub_setup(client)
279+
to_delete.append(topic_deleter)
274280
sink_name = "robots-pubsub-%d" % (_millis(),)
275281
filter_str = "logName:apache-access AND textPayload:robot"
276282
updated_filter = "textPayload:robot"
@@ -282,6 +288,7 @@ def sink_pubsub(client, to_delete):
282288
sink.create() # API call
283289
assert sink.exists() # API call
284290
# [END sink_pubsub_create]
291+
to_delete.append(sink)
285292
created_sink = sink
286293

287294
# [START client_list_sinks]

0 commit comments

Comments
 (0)