Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting does not work on Windows due to invalid metric description type name - backslash instead of slash #252

Closed
Eden90 opened this issue Jun 1, 2023 · 4 comments · Fixed by #253
Assignees
Labels
bug Something isn't working priority: p1

Comments

@Eden90
Copy link

Eden90 commented Jun 1, 2023

Hello,
I'm trying to export metrics from Windows system. It seems like the metrics exporter library is generating invalid type name for the metric description. It concatenate prefix with the metric name using the backslash instead of slash what comes up with the below error.

INVALID_ARGUMENT: Field metricDescriptor.type had an invalid value of "custom.googleapis.com\example_counter": The metric type must be a URL-formatted string with a domain and non-empty path.

I found the code piece that is responsible for generating metric type name. It uses the Path object which uses internally default operating system file separator. That's the reason why it's not working on the Windows.

I was looking for the easy work around but I couldn't find. Do you see any possibility for that?

@psx95 psx95 added the bug Something isn't working label Jun 6, 2023
@psx95
Copy link
Contributor

psx95 commented Jun 6, 2023

Hi @Eden90, thank you for reporting this.
This certainly looks like a bug and will be fixed in the next release.

As for a workaround, the only thing I can think of - can you try running your application from within a linux based VM ?

Or if switching OS is not an option, would containerizing your application via Docker help ?

@Eden90
Copy link
Author

Eden90 commented Jun 16, 2023

@psx95 I can't do that. Thanks for your PR!

@Eden90
Copy link
Author

Eden90 commented Jun 26, 2023

When can I expect new release?

@psx95
Copy link
Contributor

psx95 commented Jun 26, 2023

Hi @Eden90, we plan to create a new release this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants