Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slackbot example update to reflect package and api changes #879

Closed
wants to merge 4 commits into from

Conversation

amygdala
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2018
@amygdala
Copy link
Contributor Author

amygdala commented Nov 11, 2018

hmm, sorry... can someone remind me of the node linter I should use?
Might also need some help deciphering some of the other test errors.
(It runs for me okay..)

Ran the linter on the sample with `npm run lin -- --fix`.
@fhinkel
Copy link
Contributor

fhinkel commented Nov 12, 2018

Thanks! I ran the linter and pushed (npm run lint and npm run lint -- --fix). Do we have a Slack token we can use for the tests?

@amygdala
Copy link
Contributor Author

I'm not sure if we ever had one. Tim -- you have also created some slackbot examples... do you know if we have a test token? If not, I can generate one. @tswast

@tswast
Copy link
Contributor

tswast commented Nov 13, 2018

I created https://clouddpes.slack.com/ a while back to test Slack samples. I've still got a few apps at https://api.slack.com/apps

I'm not sure how to get a Slack API token anymore. I think they've moved to more of an OAuth2-based flow as their recommended auth mechanism.

@amygdala
Copy link
Contributor Author

It looks like it's still possible to get this kind of 'bot' token, IIUC: https://api.slack.com/docs/token-types#bot
Would you have a token you'd be willing to use for testing? (I currently just have one, so I don't want to repurpose it). @tswast
If not, I can create another one. (and maybe connect its app to that clouddpes slack?)

@fhinkel
Copy link
Contributor

fhinkel commented Nov 27, 2018

ping @amygdala Can you have a look at the merge conflict. Thanks!

@fhinkel
Copy link
Contributor

fhinkel commented Dec 14, 2018

ping @amygdala

@amygdala
Copy link
Contributor Author

ooops, sorry. This had popped off my stack. Will do!

@amygdala
Copy link
Contributor Author

amygdala commented Dec 14, 2018

(ughh, I need to figure out how to lint with node. Clearly more is needed in terms of setup than I have installed. I'll take a look on the weekend)

@amygdala
Copy link
Contributor Author

I'm rethinking: I'm having trouble finding the bandwidth to deal with this right now, and it's kind of an orphaned example anyway-- how about I just move it into one of my own repos and relink the blog post?

@amygdala
Copy link
Contributor Author

amygdala commented Jan 7, 2019

Getting back to this after the holidays. I'm closing this PR, and will just move the code into one of my own repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants