Simplify function doc samples

[grant]

• Shorthand === undefined
• Use maps rather than switch statements

[ace-n]

Missing an !?

[grant]

Done.

[ace-n]

@jmdobry @MylesBorins I like this pattern - is it sufficiently idiomatic?

[swalkowski]

I don't see req.body being explicitly set/unset by Cloud Functions on the way to HTTP function. According to https://expressjs.com/en/api.html#req.body: 'By default, it is undefined, and is populated when you use body-parsing middleware such as body-parser and multer.' Cloud Functions does use body-parser so I assume req.body should always be set.

…

On Fri, Aug 31, 2018 at 11:00 AM Ace Nassri ***@***.***> wrote: In functions/http/index.js <#717 (comment)> : > @@ -44,41 +44,28 @@ exports.helloWorld = (req, res) => { > * @param {Object} res Cloud Function response context. > */ > exports.helloContent = (req, res) => { > - let name; > - > - switch (req.get('content-type')) { > - // '{"name":"John"}' > - case 'application/json': > - name = req.body.name; > - break; > - > + let name = { One thing to bear in mind: *all* values of this dictionary will be evaluated upon dictionary creation - and *all* must succeed, regardless of the Content-Type of the incoming request. (Namely: this technique will fail if req.body is undefined. @swalkowski <https://github.com/swalkowski>, is such a thing possible?) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/717/files/3d29d13d27763d7820936a388f879a4b17605379#r214432230>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AL7pgtnBTLaaAJ7AMT4PrhY6ZgnZq1CNks5uWXmwgaJpZM4WIHnA> .

[ace-n]

Please revert this. This is enforced by our linter (semistandard).

[grant]

I'll have to fix the lint errors.

[grant]

I'm not sure exactly how to debug the failing tests, and this PR is only a stylistic change, so I'll close it.

There's something failing here:

   36:   const logs = childProcess.execSync(`functions-emulator logs read helloGCS --start-time ${startTime}`).toString();
   37:   t.true(logs.includes(`File ${filename} uploaded.`));
   38: });

  Value is not `true`:

  false

  logs.includes(`File ${filename} uploaded.`)
  => false

  `File ${filename} uploaded.`
  => 'File e176db98-2784-491d-91fd-15ee2febcc8f uploaded.'

  filename
  => 'e176db98-2784-491d-91fd-15ee2febcc8f'