Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 13 13
Lines 458 458
=======================================
Hits 445 445
Misses 13 13Continue to review full report at Codecov.
|
gguuss
approved these changes
Jan 3, 2018
Contributor
gguuss
left a comment
gguuss
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Contributor
|
I signed it! |
Contributor
|
@googlebot I signed it! |
grayside
pushed a commit
that referenced
this pull request
Oct 26, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.4](https://www.github.com/googleapis/nodejs-tasks/compare/v2.3.3...v2.3.4) (2021-06-30) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#543](https://www.github.com/googleapis/nodejs-tasks/issues/543)) ([d1a715d](https://www.github.com/googleapis/nodejs-tasks/commit/d1a715d92e0136b1840798c2e122e165201715cd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
grayside
pushed a commit
that referenced
this pull request
Nov 3, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.4](https://www.github.com/googleapis/nodejs-tasks/compare/v2.3.3...v2.3.4) (2021-06-30) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#543](https://www.github.com/googleapis/nodejs-tasks/issues/543)) ([d1a715d](https://www.github.com/googleapis/nodejs-tasks/commit/d1a715d92e0136b1840798c2e122e165201715cd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
kweinmeister
pushed a commit
that referenced
this pull request
Nov 18, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [3.3.0](https://www.github.com/googleapis/nodejs-text-to-speech/compare/v3.2.7...v3.3.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#543](https://www.github.com/googleapis/nodejs-text-to-speech/issues/543)) ([bd5ecd3](https://www.github.com/googleapis/nodejs-text-to-speech/commit/bd5ecd31f2cf39486b85c62e1f5d35850cde22b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay
pushed a commit
that referenced
this pull request
Nov 19, 2022
Committer: @medb PiperOrigin-RevId: 402631995 Source-Link: googleapis/googleapis@95af2e4 Source-Link: https://github.com/googleapis/googleapis-gen/commit/0ee7abd9ecd2951e958303681a4b251a948107b6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGVlN2FiZDllY2QyOTUxZTk1ODMwMzY4MWE0YjI1MWE5NDgxMDdiNiJ9
NimJay
pushed a commit
that referenced
this pull request
Nov 19, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [3.1.0](https://www.github.com/googleapis/nodejs-dataproc/compare/v3.0.0...v3.1.0) (2021-10-13) ### Features * add Dataproc Serverless for Spark Batches API ([#543](https://www.github.com/googleapis/nodejs-dataproc/issues/543)) ([012b56f](https://www.github.com/googleapis/nodejs-dataproc/commit/012b56fd656b22fe555c9edafbfb9a8f20c91358)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay
pushed a commit
that referenced
this pull request
Nov 19, 2022
Committer: @medb PiperOrigin-RevId: 402631995 Source-Link: googleapis/googleapis@95af2e4 Source-Link: googleapis/googleapis-gen@0ee7abd Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGVlN2FiZDllY2QyOTUxZTk1ODMwMzY4MWE0YjI1MWE5NDgxMDdiNiJ9
NimJay
pushed a commit
that referenced
this pull request
Nov 19, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [3.1.0](https://www.github.com/googleapis/nodejs-dataproc/compare/v3.0.0...v3.1.0) (2021-10-13) ### Features * add Dataproc Serverless for Spark Batches API ([#543](https://www.github.com/googleapis/nodejs-dataproc/issues/543)) ([012b56f](https://www.github.com/googleapis/nodejs-dataproc/commit/012b56fd656b22fe555c9edafbfb9a8f20c91358)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.