Skip to content

Added example with eventual read consistency in Node.js #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2017
Merged

Added example with eventual read consistency in Node.js #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e5ac9f
Example with eventual read consistency in Node.js
irri Sep 13, 2017
08ccb24
Merge branch 'master' into master
irri Sep 15, 2017
64b2858
Couple updates.
jmdobry Sep 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion datastore/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ Commands:
delete <taskId> Deletes a task.

Options:
--help Show help [boolean]
--version Show version number [boolean]
--help Show help [boolean]

Examples:
node tasks.js new "Buy milk" Adds a task with description "Buy milk".
Expand Down
18 changes: 17 additions & 1 deletion datastore/concepts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,9 +1033,25 @@ class Query extends TestHelper {

testEventualConsistentQuery (t) {
t.plan(0);
const datastoreMock = datastore;
datastore = this.datastore;
// [START eventual_consistent_query]
// Read consistency cannot be specified in google-cloud-node.
const ancestorKey = datastore.key(['TaskList', 'default']);
const query = datastore.createQuery('Task')
.hasAncestor(ancestorKey);

query.run({ consistency: 'eventual' });
// [END eventual_consistent_query]
return query.run({ consistency: 'eventual' })
.then((results) => {
datastore = datastoreMock;
const entities = results[0];
return entities;
})
.catch((err) => {
datastore = datastoreMock;
return Promise.reject(err);
});
}
}

Expand Down
8 changes: 4 additions & 4 deletions datastore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
},
"engines": {
"node": ">=4.3.2"
"node": ">=4"
},
"scripts": {
"lint": "samples lint",
Expand All @@ -18,13 +18,13 @@
},
"dependencies": {
"@google-cloud/datastore": "1.1.0",
"yargs": "8.0.2"
"yargs": "9.0.1"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "1.4.17",
"ava": "0.21.0",
"ava": "0.22.0",
"proxyquire": "1.8.0",
"sinon": "3.2.0"
"sinon": "3.3.0"
},
"cloud-repo-tools": {
"requiresKeyFile": true,
Expand Down