Skip to content

feat: Update the model name to gemini-embedding-001 #4098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Feiyang1
Copy link

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@Feiyang1 Feiyang1 requested review from a team as code owners May 23, 2025 23:57
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: aiplatform Issues related to the AI Platform API. labels May 23, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Feiyang1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request. This PR, authored by Feiyang1, aims to update the default model name used in the predict-text-embeddings.js snippet. The change specifically updates the hardcoded default value for the model parameter in the main function to reflect the new model name, gemini-embedding-001, replacing the previous text-embedding-005. This ensures the sample code is up-to-date with the latest model naming conventions.

Highlights

  • Model Name Update: The primary change is updating the default embedding model name used in the ai-platform/snippets/predict-text-embeddings.js sample.

Changelog

  • ai-platform/snippets/predict-text-embeddings.js
    • Updated the default value for the model parameter in the main function from text-embedding-005 to gemini-embedding-001 (line 23).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Model name now changed,
From old text to Gemini,
Code sample updated.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default model name in the predict-text-embeddings.js snippet to gemini-embedding-001. The change is simple and clear. My primary feedback revolves around ensuring that this new default model behavior is covered by the existing test suite.

Summary of Findings

  • Test Coverage for New Default Model: The new default model gemini-embedding-001 in predict-text-embeddings.js may not be covered by the existing test suite. Current tests appear to explicitly specify a model, thereby bypassing the default. It's recommended to add a test case to verify the script's functionality when relying on this new default model.

Merge Readiness

This pull request makes a simple update to the default model name. The code change itself is clear. However, there's a medium-severity concern regarding test coverage for this new default model. It is recommended to add a test case that specifically verifies the script's behavior with gemini-embedding-001 as the default before merging this PR. As an AI, I am not authorized to approve pull requests; this assessment is based on the review. Due to the testing concern, I recommend addressing this before merging.

@glasnt
Copy link
Contributor

glasnt commented May 26, 2025

Older ai-platform-snippets test failed, but unsure why newer tests skipped. May be issue with samples pending migration.

@gericdong
Copy link
Contributor

@Feiyang1: the integrated test of this repo doesn't support fork. I'd suggest not to use a fork and then submit a new PR.

@glasnt
Copy link
Contributor

glasnt commented May 29, 2025

I'm trying to migrate the ai-platform samples in #4100 with minimal success.

I can successfully run these tests on my local machine.

I'll create a branch to confirm the tests work with the old testing method, but I believe we should merge this PR as is to unblock this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants