-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Update the model name to gemini-embedding-001 #4098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Feiyang1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello! Gemini here, providing a summary of this pull request. This PR, authored by Feiyang1, aims to update the default model name used in the predict-text-embeddings.js
snippet. The change specifically updates the hardcoded default value for the model
parameter in the main function to reflect the new model name, gemini-embedding-001
, replacing the previous text-embedding-005
. This ensures the sample code is up-to-date with the latest model naming conventions.
Highlights
- Model Name Update: The primary change is updating the default embedding model name used in the
ai-platform/snippets/predict-text-embeddings.js
sample.
Changelog
- ai-platform/snippets/predict-text-embeddings.js
- Updated the default value for the
model
parameter in themain
function fromtext-embedding-005
togemini-embedding-001
(line 23).
- Updated the default value for the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Model name now changed,
From old text to Gemini,
Code sample updated.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the default model name in the predict-text-embeddings.js
snippet to gemini-embedding-001
. The change is simple and clear. My primary feedback revolves around ensuring that this new default model behavior is covered by the existing test suite.
Summary of Findings
- Test Coverage for New Default Model: The new default model
gemini-embedding-001
inpredict-text-embeddings.js
may not be covered by the existing test suite. Current tests appear to explicitly specify a model, thereby bypassing the default. It's recommended to add a test case to verify the script's functionality when relying on this new default model.
Merge Readiness
This pull request makes a simple update to the default model name. The code change itself is clear. However, there's a medium-severity concern regarding test coverage for this new default model. It is recommended to add a test case that specifically verifies the script's behavior with gemini-embedding-001
as the default before merging this PR. As an AI, I am not authorized to approve pull requests; this assessment is based on the review. Due to the testing concern, I recommend addressing this before merging.
Older ai-platform-snippets test failed, but unsure why newer tests skipped. May be issue with samples pending migration. |
@Feiyang1: the integrated test of this repo doesn't support fork. I'd suggest not to use a fork and then submit a new PR. |
I'm trying to migrate the ai-platform samples in #4100 with minimal success. I can successfully run these tests on my local machine. I'll create a branch to confirm the tests work with the old testing method, but I believe we should merge this PR as is to unblock this update |
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.