Skip to content

Conversation

@jmdobry
Copy link
Member

@jmdobry jmdobry commented May 16, 2017

No description provided.

@jmdobry jmdobry self-assigned this May 16, 2017
@jmdobry jmdobry requested a review from ace-n May 16, 2017 17:00
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than a minor nit.

"pretest": "npm run lint",
"unit-test": "ava -T 20s --verbose test/*.test.js",
"system-test": "ava -T 20s --verbose system-test/*.test.js",
"system-test": "ava -T 20s --verbose system-test/encryption.test.js",
Copy link
Contributor

@ace-n ace-n May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: was this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, fixed

@jmdobry jmdobry merged commit a5b1ef4 into master May 18, 2017
@jmdobry jmdobry deleted the storage-fix branch May 18, 2017 05:56
ace-n pushed a commit that referenced this pull request Nov 14, 2022
ace-n pushed a commit that referenced this pull request Nov 21, 2022
ace-n pushed a commit that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants