Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLP: Added sample for k anonymity with entity ID and deidentify cloud storage #3364

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

dinesh-crest
Copy link
Contributor

Added unit test cases for same

Description

References:- https://cloud.google.com/dlp/docs/deidentify-storage#code-example
https://cloud.google.com/dlp/docs/visualizing_re-id_risk.md?g=0&l=119#step_1_calculate_k-anonymity_on_the_dataset

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@dinesh-crest dinesh-crest requested review from a team as code owners July 27, 2023 10:21
@snippet-bot
Copy link

snippet-bot bot commented Jul 27, 2023

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples. labels Jul 27, 2023
@dinesh-crest dinesh-crest force-pushed the k_anonym_deidentify_cloud_storage branch from 4b9bd20 to 0785ab9 Compare July 27, 2023 10:24
@annadata annadata force-pushed the k_anonym_deidentify_cloud_storage branch from 5ea10ad to 33fb3ae Compare August 1, 2023 06:47
@dinesh-crest dinesh-crest force-pushed the k_anonym_deidentify_cloud_storage branch from 33fb3ae to 50e0d43 Compare August 4, 2023 05:18
@annadata annadata force-pushed the k_anonym_deidentify_cloud_storage branch 2 times, most recently from 4137cbd to 22029a2 Compare August 9, 2023 15:41
@annadata annadata assigned annadata and unassigned soumya92 Aug 9, 2023
Copy link

@annadata annadata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the minor review comments.

dlp/kAnonymityWithEntityIds.js Outdated Show resolved Hide resolved
dlp/kAnonymityWithEntityIds.js Outdated Show resolved Hide resolved
dlp/kAnonymityWithEntityIds.js Outdated Show resolved Hide resolved
dlp/deIdentifyCloudStorage.js Outdated Show resolved Hide resolved
@kweinmeister
Copy link
Collaborator

@dinesh-crest please fix merge conflicts.

@annadata this particular file has merge conflicts very frequently. maybe we can think about how we change this file to avoid these in the future, or split the test file.

@dinesh-crest dinesh-crest force-pushed the k_anonym_deidentify_cloud_storage branch from ca26e87 to 6456726 Compare August 14, 2023 10:40
@pattishin
Copy link
Contributor

@dinesh-crest Whenever you have some time, could you resolve the file conflicts that are popping up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants