Updated the version of spanner library #334

vkedia · 2017-04-04T20:57:49Z

Also changed the samples code to work with that.

…k with that.

ace-n

LGTM once you change the callbacks to promises

ace-n · 2017-04-04T21:00:34Z

spanner/transaction.js

-        .then((results) => {
-          const rows = results[0];
-
+      transaction.run(queryOne, function(err, rows) {


Avoid callbacks and the function keyword - stick to promises and arrow functions where possible.

ace-n · 2017-04-04T21:01:49Z

spanner/transaction.js

+      	  // Read #2, using the `read` method. Even if changes occur
+      	  // in-between the reads, the transaction ensures that both
+          // return the same data.
+          transaction.read('Albums', queryTwo, function(err, rows) {


Ditto callbacks v. promises

ace-n · 2017-04-04T21:02:51Z

spanner/transaction.js

-      ]);
-    })
-    .then(() => {
+  database.runTransaction(function(err, transaction) {


Ditto callbacks vs. promises.

database.runTransaction no longer returns a Promise. This was a change made in the latest release

ace-n · 2017-04-04T21:03:48Z

spanner/transaction.js

-      console.log(`Successfully executed read-write transaction to transfer ${transferAmount} from Album 2 to Album 1.`);
-    });
-    // [END read_write_transaction]
+    .then(() => transaction.commit(function(err) {


Ditto callbacks vs. promises.

I don't think commit returns a Promise.

vkedia · 2017-04-04T22:03:53Z

Changed callbacks to promises wherever possible. Please take a look.

ace-n · 2017-04-05T20:38:18Z

spanner/transaction.js

-      const queryOne = 'SELECT SingerId, AlbumId, AlbumTitle FROM Albums';
+  database.runTransaction({readOnly: true}, (err, transaction) => {
+    if (err) {
+        // Error handling omitted.


Replace with console.error(err) to avoid failing silently. Ditto for all the other callbacks in this change.

vkedia · 2017-04-05T22:08:23Z

Done.

…

On Wed, Apr 5, 2017 at 2:06 PM, Ace Nassri ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In spanner/transaction.js <#334 (comment)> : > @@ -33,46 +33,42 @@ function readOnlyTransaction (instanceId, databaseId) { // Gets a transaction object that captures the database state // at a specific point in time - database.runTransaction({readOnly: true}) - .then((results) => { - const transaction = results[0]; - - const queryOne = 'SELECT SingerId, AlbumId, AlbumTitle FROM Albums'; + database.runTransaction({readOnly: true}, (err, transaction) => { + if (err) { + // Error handling omitted. Replace with console.error(err) to avoid failing silently. Ditto for all the other callbacks in this change. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#334 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATdef5tCrrTJ-Us8vk8fUF3tQeO-aJnEks5rtAJVgaJpZM4MzayO> .

ace-n

One minor nit, and we should be good to go.

ace-n · 2017-04-05T22:12:16Z

spanner/transaction.js

-      ]);
-    })
-    .then(() => {
+  database.runTransaction(function (err, transaction) {


Nit: use arrow functions.

ace-n · 2017-04-05T22:12:30Z

spanner/transaction.js

-      console.log(`Successfully executed read-write transaction to transfer ${transferAmount} from Album 2 to Album 1.`);
-    });
-    // [END read_write_transaction]
+    .then(() => transaction.commit(function (err) {


Nit: use arrow functions

* Updated the version of spanner library and changed the samples to work with that. * Fixed some lint errors * Converted callbacks to promises wherever possible * Fixed error handling * Used arrow functions

* chore(main): release 3.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: initial release of cloud build library (#2) * feat(docs): add listBuildTriggers sample to README (#5) * feat: moves library to TypeScript code generation (#10) * chore: release 1.0.0 (#3) * chore: release 1.1.0 (#20) * chore: update license headers * chore: release 1.2.0 (#25) * chore: release 1.3.0 (#33) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * chore(deps): update dependency c8 to v7 (#38) * refactor: use explicit mocha imports (#40) * chore(deps): update dependency mocha to v7 (#43) * chore: release 1.3.1 * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * chore: release 1.3.2 (#49) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * chore: release 1.3.3 (#59) * chore: release 1.4.0 (#63) * chore: release 1.5.0 (#67) * chore(deps): update dependency mocha to v8 (#122) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://togithub.com/mochajs/mocha)) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/mocha/7.2.0/8.0.1) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v8.0.1`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#801--2020-06-10) [Compare Source](https://togithub.com/mochajs/mocha/compare/v8.0.0...v8.0.1) The obligatory patch after a major. #### 🐛 Fixes - [#4328](https://togithub.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@boneskull**](https://togithub.com/boneskull)) ### [`v8.0.0`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#800--2020-06-10) [Compare Source](https://togithub.com/mochajs/mocha/compare/v7.2.0...v8.0.0) In this major release, Mocha adds the ability to _run tests in parallel_. Better late than never! Please note the **breaking changes** detailed below. Let's welcome [**@giltayar**](https://togithub.com/giltayar) and [**@nicojs**](https://togithub.com/nicojs) to the maintenance team! #### 💥 Breaking Changes - [#4164](https://togithub.com/mochajs/mocha/issues/4164): **Mocha v8.0.0 now requires Node.js v10.0.0 or newer.** Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 ([**@UlisesGascon**](https://togithub.com/UlisesGascon)) - [#4175](https://togithub.com/mochajs/mocha/issues/4175): Having been deprecated with a warning since v7.0.0, **`mocha.opts` is no longer supported** ([**@juergba**](https://togithub.com/juergba)) ✨ **WORKAROUND:** Replace `mocha.opts` with a [configuration file](https://mochajs.org/#configuring-mocha-nodejs). - [#4260](https://togithub.com/mochajs/mocha/issues/4260): Remove `enableTimeout()` (`this.enableTimeout()`) from the context object ([**@craigtaub**](https://togithub.com/craigtaub)) ✨ **WORKAROUND:** Replace usage of `this.enableTimeout(false)` in your tests with `this.timeout(0)`. - [#4315](https://togithub.com/mochajs/mocha/issues/4315): The `spec` option no longer supports a comma-delimited list of files ([**@juergba**](https://togithub.com/juergba)) ✨ **WORKAROUND**: Use an array instead (e.g., `"spec": "foo.js,bar.js"` becomes `"spec": ["foo.js", "bar.js"]`). - [#4309](https://togithub.com/mochajs/mocha/issues/4309): Drop support for Node.js v13.x line, which is now End-of-Life ([**@juergba**](https://togithub.com/juergba)) - [#4282](https://togithub.com/mochajs/mocha/issues/4282): `--forbid-only` will throw an error even if exclusive tests are avoided via `--grep` or other means ([**@arvidOtt**](https://togithub.com/arvidOtt)) - [#4223](https://togithub.com/mochajs/mocha/issues/4223): The context object's `skip()` (`this.skip()`) in a "before all" (`before()`) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites ([**@juergba**](https://togithub.com/juergba)) - [#4178](https://togithub.com/mochajs/mocha/issues/4178): Remove previously soft-deprecated APIs ([**@wnghdcjfe**](https://togithub.com/wnghdcjfe)): - `Mocha.prototype.ignoreLeaks()` - `Mocha.prototype.useColors()` - `Mocha.prototype.useInlineDiffs()` - `Mocha.prototype.hideDiff()` #### 🎉 Enhancements - [#4245](https://togithub.com/mochajs/mocha/issues/4245): Add ability to run tests in parallel for Node.js (see [docs](https://mochajs.org/#parallel-tests)) ([**@boneskull**](https://togithub.com/boneskull)) ❗ See also [#4244](https://togithub.com/mochajs/mocha/issues/4244); [Root Hook Plugins (docs)](https://mochajs.org/#root-hook-plugins) -- _root hooks must be defined via Root Hook Plugins to work in parallel mode_ - [#4304](https://togithub.com/mochajs/mocha/issues/4304): `--require` now works with ES modules ([**@JacobLey**](https://togithub.com/JacobLey)) - [#4299](https://togithub.com/mochajs/mocha/issues/4299): In some circumstances, Mocha can run ES modules under Node.js v10 -- _use at your own risk!_ ([**@giltayar**](https://togithub.com/giltayar)) #### 📖 Documentation - [#4246](https://togithub.com/mochajs/mocha/issues/4246): Add documentation for parallel mode and Root Hook plugins ([**@boneskull**](https://togithub.com/boneskull)) #### 🐛 Fixes (All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above) </details> --- ### Renovate configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-cloudbuild). * chore: release 2.0.0 (#92) :robot: I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v1.5.0...v2.0.0) (2020-06-11) ### ⚠ BREAKING CHANGES * The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM. ### Features * add time-to-live in a queue for builds ([04e3387](https://www.github.com/googleapis/nodejs-cloudbuild/commit/04e3387af33a7ab39eb0c4df47ce08026507b499)) * check status of long running operation by its name ([#114](https://www.github.com/googleapis/nodejs-cloudbuild/issues/114)) ([7b50a74](https://www.github.com/googleapis/nodejs-cloudbuild/commit/7b50a74c098e782393f92140a37e3bd26f45e77d)) * drop node8 support, support for async iterators ([#91](https://www.github.com/googleapis/nodejs-cloudbuild/issues/91)) ([74a195d](https://www.github.com/googleapis/nodejs-cloudbuild/commit/74a195d5cdf63dab1ac3d0d52ef42e1254ab3a2e)) * improve support for x-goog-request-params ([#111](https://www.github.com/googleapis/nodejs-cloudbuild/issues/111)) ([e08d640](https://www.github.com/googleapis/nodejs-cloudbuild/commit/e08d64017e059c911ebe55055c26a0ab76481d86)) * move ts target to es2018 from es2016 ([#121](https://www.github.com/googleapis/nodejs-cloudbuild/issues/121)) ([59c5477](https://www.github.com/googleapis/nodejs-cloudbuild/commit/59c547744519ef9e8d073ea3ecdb81248176a71a)) ### Bug Fixes * remove eslint, update gax, fix generated protos, run the generator ([#100](https://www.github.com/googleapis/nodejs-cloudbuild/issues/100)) ([aafb9cc](https://www.github.com/googleapis/nodejs-cloudbuild/commit/aafb9cc7745b4d5d6dce58f17763f76379af733f)) * synth.py clean up for multiple version ([#115](https://www.github.com/googleapis/nodejs-cloudbuild/issues/115)) ([aa7d99b](https://www.github.com/googleapis/nodejs-cloudbuild/commit/aa7d99b9c02267808cac07f7691f5ce62f06ca14)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore: release 2.0.1 (#126) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.0.2 (#133) :robot: I have created a release \*beep\* \*boop\* --- ### [2.0.2](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.0.1...v2.0.2) (2020-07-09) ### Bug Fixes * typeo in nodejs .gitattribute ([#132](https://www.github.com/googleapis/nodejs-cloudbuild/issues/132)) ([80b5bd9](https://www.github.com/googleapis/nodejs-cloudbuild/commit/80b5bd963aa43e5a47da9e6d0e2ffbf0cde7feef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore: release 2.0.3 (#143) * chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.0.4 (#179) :robot: I have created a release \*beep\* \*boop\* --- ### [2.0.4](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.0.3...v2.0.4) (2020-11-03) ### ⚠ BREAKING CHANGES * The WorkerPool API in the v1 surface has been long deprecated, so it has been deleted from the v1 surface. Alpha WorkerPool customers who want to call the WorkerPool API can use gcloud. ### Features * updated third_party Cloud Build clients with new Build message, fix: revert removal of WorkerPool API ([#166](https://www.github.com/googleapis/nodejs-cloudbuild/issues/166)) ([b8d7a39](https://www.github.com/googleapis/nodejs-cloudbuild/commit/b8d7a395bbcc2f6ff83b798ef678e2f27395802d)) ### Bug Fixes * revert removal of WorkerPool API ([#178](https://www.github.com/googleapis/nodejs-cloudbuild/issues/178)) ([07400cb](https://www.github.com/googleapis/nodejs-cloudbuild/commit/07400cbcb05808762ab3c56c5827607cdefd43c0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore: release 2.0.5 (#182) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.0.6 (#186) :robot: I have created a release \*beep\* \*boop\* --- ### [2.0.6](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.0.5...v2.0.6) (2020-11-25) ### Bug Fixes * check for fetch on window ([#185](https://www.github.com/googleapis/nodejs-cloudbuild/issues/185)) ([115de71](https://www.github.com/googleapis/nodejs-cloudbuild/commit/115de7141262c119113759aee5ddc141d129b55d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore: release 2.1.0 (#205) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.0 (#213) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com> * chore: release 2.2.1 (#220) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.2 (#227) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.3 (#232) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.4 (#242) :robot: I have created a release \*beep\* \*boop\* --- ### [2.2.4](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.2.3...v2.2.4) (2021-06-24) ### Bug Fixes * make request optional in all cases ([#241](https://www.github.com/googleapis/nodejs-cloudbuild/issues/241)) ([c96003a](https://www.github.com/googleapis/nodejs-cloudbuild/commit/c96003a4897d3f7c8181a56c273b842a4dcdfbf7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.2.5 (#247) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.6 (#250) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.7 (#252) :robot: I have created a release \*beep\* \*boop\* --- ### [2.2.7](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.2.6...v2.2.7) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#251](https://www.github.com/googleapis/nodejs-cloudbuild/issues/251)) ([7bc5f7f](https://www.github.com/googleapis/nodejs-cloudbuild/commit/7bc5f7ff6c1485baaf1444a608d8ebb88ad20cfe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.3.0 (#263) :robot: I have created a release \*beep\* \*boop\* --- ## [2.3.0](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.2.7...v2.3.0) (2021-08-05) ### ⚠ BREAKING CHANGES * * feat: add a WorkerPools API ### Features * add a WorkerPools API ([#254](https://www.github.com/googleapis/nodejs-cloudbuild/issues/254)) ([2e5b3f5](https://www.github.com/googleapis/nodejs-cloudbuild/commit/2e5b3f540d9cd2b3a616c4581b07ebcfc444e7c7)) * Implementation of Build Failure Info: - Added message FailureInfo field ([#255](https://www.github.com/googleapis/nodejs-cloudbuild/issues/255)) ([6f115e2](https://www.github.com/googleapis/nodejs-cloudbuild/commit/6f115e2a4ec78289014c05f398d8464e599b1ef6)) ### Build System * force a minor release ([#262](https://www.github.com/googleapis/nodejs-cloudbuild/issues/262)) ([bc43706](https://www.github.com/googleapis/nodejs-cloudbuild/commit/bc4370692e233c265ce45546b205b9b9925d3990)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.3.1 (#266) :robot: I have created a release \*beep\* \*boop\* --- ### [2.3.1](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.3.0...v2.3.1) (2021-08-12) ### Bug Fixes * **build:** migrate to using main branch ([#265](https://www.github.com/googleapis/nodejs-cloudbuild/issues/265)) ([e89f829](https://www.github.com/googleapis/nodejs-cloudbuild/commit/e89f829f10c5710ca5fb259a6c8dfae1527071a3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.3.2 (#269) :robot: I have created a release \*beep\* \*boop\* --- ### [2.3.2](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.3.1...v2.3.2) (2021-08-16) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#268](https://www.github.com/googleapis/nodejs-cloudbuild/issues/268)) ([c26f7f7](https://www.github.com/googleapis/nodejs-cloudbuild/commit/c26f7f726db4f43f3692aea4c516547abcddd0ea)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.4.0 (#270) :robot: I have created a release \*beep\* \*boop\* --- ## [2.4.0](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.3.2...v2.4.0) (2021-08-16) ### Features * Add ability to configure BuildTriggers to create Builds that require approval before executing and ApproveBuild API to approve or reject pending Builds ([#267](https://www.github.com/googleapis/nodejs-cloudbuild/issues/267)) ([18ec067](https://www.github.com/googleapis/nodejs-cloudbuild/commit/18ec067ac1e112836c5d56747dda89e04f87c481)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.5.0 (#272) :robot: I have created a release \*beep\* \*boop\* --- ## [2.5.0](https://www.github.com/googleapis/nodejs-cloudbuild/compare/v2.4.0...v2.5.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#271](https://www.github.com/googleapis/nodejs-cloudbuild/issues/271)) ([dcb970d](https://www.github.com/googleapis/nodejs-cloudbuild/commit/dcb970d8a6a7d87da553667cd25f8eb1052ba047)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.6.0 (#275) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * docs(samples): add example tags to generated samples (#287) * docs(samples): add example tags to generated samples PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: googleapis/googleapis-gen@eb888bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: change node version for sample Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com> * chore(quickstart): mention private pool caveats (#317) * build!: update library to use Node 12 (#325) * feat!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 3.0.0 (#326) * chore(main): release 3.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 3.0.1 (#328) :robot: I have created a release *beep* *boop* --- ## [3.0.1](googleapis/nodejs-cloudbuild@v3.0.0...v3.0.1) (2022-06-20) ### Bug Fixes * fixes for dynamic routing and streaming descriptors ([#327](googleapis/nodejs-cloudbuild#327)) ([4cf9b63](googleapis/nodejs-cloudbuild@4cf9b63)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore(main): release 3.1.0 (#334) * chore(main): release 3.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 3.1.1 (#340) * chore(main): release 3.1.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 3.1.2 (#345) * chore(main): release 3.1.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * testing(cloudbuild): Add GitHub Workflows integration for test running * chore(CODEOWNERS): Add cloudbuild ownership Co-authored-by: Benjamin E. Coe <bencoe@google.com> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com> Co-authored-by: Ace Nassri <anassri@google.com> Co-authored-by: Alexander Fenster <fenster@google.com>

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix region tag * fix: region tag

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

vkedia added 2 commits April 4, 2017 13:44

Updated the version of spanner library and changed the samples to wor…

4bbad15

…k with that.

Fixed some lint errors

43d28a4

ace-n suggested changes Apr 4, 2017

View reviewed changes

Converted callbacks to promises wherever possible

026b2cb

Merge branch 'master' into txn-retry

b93f54c

ace-n mentioned this pull request Apr 5, 2017

spanner: how should transactional promises look? googleapis/google-cloud-node#2152

Closed

ace-n suggested changes Apr 5, 2017

View reviewed changes

Fixed error handling

cbf5f43

ace-n suggested changes Apr 5, 2017

View reviewed changes

vkedia added 2 commits April 5, 2017 15:45

Used arrow functions

b698735

Merge branch 'master' into txn-retry

9541f13

ace-n merged commit 4fa04af into GoogleCloudPlatform:master Apr 17, 2017

snyk-bot mentioned this pull request Dec 23, 2020

[Snyk] Security upgrade @google-cloud/vision from 0.24.0 to 0.25.0 leejh3224/nodejs-docs-samples#290

Open

ninadhatkar mentioned this pull request Jun 30, 2022

[Snyk] Security upgrade twilio from 2.11.1 to 3.17.1 ninadhatkar/nodejs-docs-samples#265

Open

ahrarmonsur pushed a commit that referenced this pull request Nov 8, 2022

chore: release 1.6.1 (#334)

95b9cd1

ahrarmonsur mentioned this pull request Nov 8, 2022

samples: migrate code from googleapis/nodejs-monitoring #2807

Merged

ace-n pushed a commit that referenced this pull request Nov 10, 2022

chore: release 1.6.1 (#334)

095bb38

grayside mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-cloudbuild #2823

Closed

grayside mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-cloudbuild #2824

Merged

ace-n pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): update dependency uuid to v7 (#334)

32f3bcc

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-automl #2841

Merged

migrate code from googleapis/nodejs-document-ai #2842

Closed

ace-n pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): update dependency uuid to v7 (#334)

33e00e0

ace-n mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-document-ai #2843

Merged

ace-n pushed a commit that referenced this pull request Nov 14, 2022

chore: release 1.1.1 (#334)

eb2d0f2

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

ace-n mentioned this pull request Nov 14, 2022

migrate code from googleapis/nodejs-compute #2846

Closed

ace-n pushed a commit that referenced this pull request Nov 14, 2022

chore(deps): update dependency uuid to v7 (#334)

f1c8e52

ace-n pushed a commit that referenced this pull request Nov 15, 2022

chore(deps): update dependency uuid to v7 (#334)

ef6e55a

ace-n mentioned this pull request Nov 15, 2022

migrate code from googleapis/nodejs-compute #2853

Merged

ace-n pushed a commit that referenced this pull request Nov 15, 2022

chore(deps): update dependency uuid to v7 (#334)

fecf51c

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency uuid to v7 (#334)

22b532c

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency uuid to v7 (#334)

a0e553a

ace-n pushed a commit that referenced this pull request Nov 17, 2022

fix: hybrid glossary tutorial region tag (#334)

6921613

* fix region tag * fix: region tag

ace-n mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-translate #2862

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

fix: hybrid glossary tutorial region tag (#334)

21f9931

* fix region tag * fix: region tag

ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency uuid to v7 (#334)

2843010

ace-n pushed a commit that referenced this pull request Nov 17, 2022

fix: hybrid glossary tutorial region tag (#334)

1017b9b

* fix region tag * fix: region tag

ace-n pushed a commit that referenced this pull request Nov 17, 2022

fix: hybrid glossary tutorial region tag (#334)

5e185fc

* fix region tag * fix: region tag

ace-n pushed a commit that referenced this pull request Nov 17, 2022

fix: hybrid glossary tutorial region tag (#334)

e67b480

* fix region tag * fix: region tag

ace-n pushed a commit that referenced this pull request Nov 21, 2022

chore: release 1.1.1 (#334)

0f83260

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

ace-n pushed a commit that referenced this pull request Nov 21, 2022

chore: release 1.1.1 (#334)

afd9e3d

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

Shabirmean pushed a commit that referenced this pull request Feb 16, 2023

tests: sample integration tests relied on deleted dataset (#334)

78f32cb

Shabirmean mentioned this pull request Feb 16, 2023

samples: migrate code from googleapis/nodejs-dlp #3035

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated the version of spanner library #334

Updated the version of spanner library #334

vkedia commented Apr 4, 2017

ace-n left a comment

ace-n Apr 4, 2017

ace-n Apr 4, 2017

ace-n Apr 4, 2017

vkedia Apr 4, 2017

ace-n Apr 4, 2017

vkedia Apr 4, 2017

vkedia commented Apr 4, 2017

ace-n Apr 5, 2017

vkedia commented Apr 5, 2017 via email

ace-n left a comment

ace-n Apr 5, 2017

vkedia Apr 5, 2017

ace-n Apr 5, 2017

vkedia Apr 5, 2017

Updated the version of spanner library #334

Updated the version of spanner library #334

Conversation

vkedia commented Apr 4, 2017

ace-n left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vkedia commented Apr 4, 2017

Choose a reason for hiding this comment

vkedia commented Apr 5, 2017 via email

ace-n left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment