Skip to content

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented Feb 14, 2017

(FYI these were already reviewed by @jmdobry. @jonparrott, these should be good to merge - but feel free to skim them + verify.)

@ace-n ace-n requested a review from theacodes February 14, 2017 18:40
.gitignore Outdated
@@ -1,3 +1,6 @@
.DS_Store

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes in your global gitignore, not in the repositories.

@jmdobry jmdobry self-requested a review February 14, 2017 18:43
Copy link
Member

@jmdobry jmdobry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to sync package.json files via scrpts/unify

Copy link
Member

@jmdobry jmdobry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but only because the test script isn't smart enough to recognize new tests. The spanner tests won't actually run until this is merged.

@ace-n ace-n merged commit dfc3639 into master Feb 14, 2017
@ace-n ace-n deleted the spanner-samples branch April 5, 2017 01:07
NimJay pushed a commit that referenced this pull request Nov 11, 2022
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 11, 2022
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 14, 2022
ace-n pushed a commit that referenced this pull request Nov 14, 2022
ace-n pushed a commit that referenced this pull request Nov 14, 2022
ace-n pushed a commit that referenced this pull request Nov 15, 2022
kweinmeister pushed a commit that referenced this pull request Nov 18, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
…313)

This reverts commit ddf8546fa576b36c6094e73aad8181c102ff5f41.
pattishin pushed a commit that referenced this pull request Nov 18, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): added create-featurestore sample (#313)

* feat(samples): added variation of create-featurestore sample (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 18, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add remaining featurestore api samples (#313)

* feat(samples): add remaining featurestore apis samples (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(samples): changed timeout of featurestore apis samples (#313)

* feat(samples): update featurestore-samples.test.js (#313)

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 18, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add entity type apis samples (#313)

* feat(samples): changed timeout for entity type apis samples (#313)

* feat(samples): update entity-type-samples.test.js (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 18, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add feature apis samples (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(samples): updated feature-samples.test.js (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 18, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add feature-values apis samples (#313)

* feat(samples): add feature values apis samples (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(samples): update dependency featurevalues apis (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 22, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): added create-featurestore sample (#313)

* feat(samples): added variation of create-featurestore sample (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 22, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add remaining featurestore api samples (#313)

* feat(samples): add remaining featurestore apis samples (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(samples): changed timeout of featurestore apis samples (#313)

* feat(samples): update featurestore-samples.test.js (#313)

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 22, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add entity type apis samples (#313)

* feat(samples): changed timeout for entity type apis samples (#313)

* feat(samples): update entity-type-samples.test.js (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 22, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add feature apis samples (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(samples): updated feature-samples.test.js (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 22, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add feature-values apis samples (#313)

* feat(samples): add feature values apis samples (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat(samples): update dependency featurevalues apis (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants