-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add option to generate one workflow #2822
Conversation
This is a good idea. Thanks for adding this, Karl! I've tested:
All 3 scenarios worked as expected. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion (variable rename) is a nitpick. Feel free to ignore.
Approved!
Co-authored-by: Nim Jayawardena <i.am.nim.jay@gmail.com>
Co-authored-by: Nim Jayawardena <i.am.nim.jay@gmail.com>
Thanks for the review, @NimJay ! Accepted your changes. |
Also, this reminded me to update |
It looks like the CLA check is failing because of my email address. Update: I have overridden the CLA check. ✅ |
The workflow generation script currently creates all workflows, every time it is run.
This minor change enables an extra optional parameter with the workflow title, e.g.
cloud-tasks
.A workflow will only be generated if it matches that parameter. If the parameter is not specified, the behavior remains the same, generating all workflows.