Skip to content

chore: activate more eslint rules #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2020
Merged

chore: activate more eslint rules #2038

merged 5 commits into from
Oct 31, 2020

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Oct 30, 2020

activate no-process-exit lint rule
activate no-process-exit rule

See #2030

@fhinkel fhinkel requested a review from kurtisvg as a code owner October 30, 2020 07:25
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2020
@fhinkel fhinkel requested a review from ace-n October 30, 2020 07:25
ace-n
ace-n approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll let @engelke or @grayside sign off on the Run URL change.

@fhinkel fhinkel requested review from engelke and grayside October 30, 2020 08:29
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 30, 2020
@fhinkel fhinkel force-pushed the fhinkel-no-process-exit branch from 428f096 to 9dc5701 Compare October 30, 2020 13:38
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 30, 2020
@fhinkel fhinkel force-pushed the fhinkel-no-process-exit branch from 9dc5701 to 89a8b0d Compare October 30, 2020 13:59
@fhinkel fhinkel force-pushed the fhinkel-no-process-exit branch from 89a8b0d to cc0d046 Compare October 30, 2020 14:00
kurtisvg
kurtisvg approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for /cloudsql

engelke
engelke approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for URL

@fhinkel fhinkel merged commit b4b472a into master Oct 31, 2020
@fhinkel fhinkel deleted the fhinkel-no-process-exit branch October 31, 2020 05:16
This was referenced Jan 11, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 20, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grayside grayside grayside approved these changes

+3 more reviewers

@engelke engelke engelke approved these changes

@ace-n ace-n ace-n approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fhinkel @engelke @grayside @ace-n @kurtisvg @kokoro-team