Fix typo #200
Merged
Fix typo #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grayside
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Task with authentication sample * Update region tags * Linting error * Small updates * Add real service account to tests * Update queue id
grayside
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Task with authentication sample * Update region tags * Linting error * Small updates * Add real service account to tests * Update queue id
NimJay
pushed a commit
that referenced
this pull request
Nov 9, 2022
Use new effective_severity field fixes b/142836422
kweinmeister
pushed a commit
that referenced
this pull request
Nov 10, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
This was referenced Nov 11, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 11, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Vision-GA - vision_localize_objects & vision_localize_object_gcs * Vision-GA - README file updates * Vision-GA - Fixes after review * Vision-GA - Fixes after review
unforced
pushed a commit
that referenced
this pull request
Nov 17, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 18, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [3.3.0](https://www.github.com/googleapis/nodejs-secret-manager/compare/v3.2.3...v3.3.0) (2021-01-09) ### Features * adds style enumeration ([#199](https://www.github.com/googleapis/nodejs-secret-manager/issues/199)) ([d99b4af](https://www.github.com/googleapis/nodejs-secret-manager/commit/d99b4af960182916b9a5ed0dfd1f12a2148729fb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kweinmeister
pushed a commit
that referenced
this pull request
Jan 11, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/nodejs-retail/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I know we're planning to get rid of JSDoc comments, but I thought this was worth fixing before I included this sample on the docs.)