-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore:refactor memcached test #1698
Merged
gcf-merge-on-green
merged 12 commits into
GoogleCloudPlatform:master
from
sofisl:memcachedTest
Apr 16, 2020
Merged
chore:refactor memcached test #1698
gcf-merge-on-green
merged 12 commits into
GoogleCloudPlatform:master
from
sofisl:memcachedTest
Apr 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Apr 1, 2020
fhinkel
reviewed
Apr 1, 2020
appengine/memcached/package.json
Outdated
}, | ||
"dependencies": { | ||
"express": "^4.16.4", | ||
"memjs": "^1.2.0" | ||
}, | ||
"devDependencies": { | ||
"@google-cloud/nodejs-repo-tools": "^3.3.0" | ||
"@google-cloud/nodejs-repo-tools": "^3.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove repo-tools
?
fhinkel
approved these changes
Apr 16, 2020
fhinkel
added
kokoro:run
Add this label to force Kokoro to re-run the tests.
automerge
Merge the pull request once unit tests and other checks pass.
labels
Apr 16, 2020
kokoro-team
removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
labels
Apr 16, 2020
This was referenced Nov 17, 2020
This was referenced Nov 18, 2020
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.