Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example showing bug with gcloud and sibling directories #1577

Closed
wants to merge 3 commits into from

Conversation

janakdr
Copy link

@janakdr janakdr commented Dec 26, 2019

With this patch, running from appengine/hello-world/sibling/subdir/index.js, both npm start and yarn start succeed. However, running gcloud app deploy fails. If using npm, it seems to not find the package.json file in the subdirectory:

Step #1 - "builder": npm ERR! Could not install from "../sibling" as it does not contain a package.json file.

If yarn.lock is present, it fails with a stranger error:

Step #1 - "builder": error Package "sibling-dep" refers to a non-existing file '"/sibling"'.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 26, 2019
@janakdr
Copy link
Author

janakdr commented Dec 26, 2019

Sorry, I didn't actually want to add this as a PR to the original repository. Just wanted to create a patch showing the issue in order to file an internal bug. Please ignore!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants