-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace app engine js compilation with ts-node #1570
Replace app engine js compilation with ts-node #1570
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@sashamor Thanks for the pull request. In our docs, we want to explicitely show how to compile TypeScript sources instead of using ts-node. Thank for understanding. |
Replace app engine js compilation step with running ts-node on the app engine server.
As ts-node gains popularity, the benefits of debugging and instrumenting typescript code in real-time justify skipping compilation to JS altogether.
Not sure if this has already been considered. Also note that
repo-tools test
may not support testing typescript code directly, although many popular typescript testing libraries (e.g. jest) do support this.