Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Catalog: add delete fileset Entry sample #1569

Conversation

ricardolsmendes
Copy link
Contributor

Fileset operations were added to Data Catalog's API and the client library now supports them. Samples are required to update the official docs.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2019
@ricardolsmendes
Copy link
Contributor Author

This change depends on googleapis/nodejs-datacatalog#74 to pass the system tests.

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fhinkel is there a reason we'd put this here and not googleapis/nodejs-datacatalog?

@ricardolsmendes
Copy link
Contributor Author

@fhinkel is there a reason we'd put this here and not googleapis/nodejs-datacatalog?

Hi, @JustinBeckwith and @fhinkel,
I discussed with @bcoe a while ago and this is what we agreed so far:

  1. the present change should be part of this repository because its main code includes more than one API call and is intended to be referred by Quickstart guides in Data Catalog docs;
  2. the same applies to Data Catalog: add create fileset Entry sample #1568;
  3. once the quickstart-related changes have been merged, we should move the samples residing at https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/master/datacatalog/cloud-client to googleapis/nodejs-datacatalog, since each of them represents a single API call and would work as smoke tests to the client library as well.

Please let me know your thoughts.

Kind regards,
Ricardo

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 11, 2020
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 11, 2020
@JustinBeckwith JustinBeckwith requested review from JustinBeckwith and removed request for JustinBeckwith February 11, 2020 20:53
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this, but please let @fhinkel have a look

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this, but please let @fhinkel have a looksy

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020
@fhinkel
Copy link
Contributor

fhinkel commented Feb 13, 2020

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants