Cloud client library migration part 1: Registry management #1558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
FYI the tests are failing outside of this change. |
hongalex
reviewed
Dec 5, 2019
Contributor
Author
|
@hongalex PTAL, updated the logging as appropriate and addressed nits. |
hongalex
reviewed
Dec 5, 2019
Contributor
hongalex
left a comment
hongalex
left a comment
There was a problem hiding this comment.
Sorry, I wanted to print all the errors with console.error instead. Marked the places that need to be updated.
Contributor
Author
|
I went ahead and cleaned up the whole file, there was inconsistent use of console error and log. |
This was referenced Dec 23, 2020
This was referenced Feb 10, 2022
This was referenced Apr 29, 2022
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.