-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tools.checkCredentials() #1555
Conversation
We want to remove the nodejs-repo-tools dependency. Doing so step by step.
Isn't this introducing a lot of duplicated code? |
The point is to get rid of helper methods. Samples need to be self contained. Black box helper methods like |
From the PR sent, it looked like the motivation was to remove the dependency with |
We want to remove the nodejs-repo-tools dependency. Doing so step by step.
Drive-by fix: Rename
utils
totools
for consistency.