Skip to content

Conversation

@fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Nov 26, 2019

  • Update Node version to 10 for GAE Standard.
  • Delete repo-tools.
  • Clean up package.json

@fhinkel fhinkel requested a review from kurtisvg as a code owner November 26, 2019 22:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 26, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 26, 2019
gcloud app browse
```

## Deploy to Google App Engine Flexible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we deleting the Flex instructions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see it used in our docs. We recommend people use GAE Standard.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 to removing flex now that Cloud Run is GA. Question - do we have broad guidance to do this across the docs and sample sets? Would be good to have something written down.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We moved almost all samples to GAE Standard more than a year ago. @michaelawyu was there a document for those changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely don't want to do that for this sample. There are differences between how Standard / Flex interact with Cloud SQL and part of the point of these samples to show how to do that for each.

Update Node version to 10 for GAE Standard.
Delete repo-tools.
Clean up package.json
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 27, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants