Skip to content

run/logging-manual: stabilize tests #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 27, 2020
Merged

run/logging-manual: stabilize tests #1515

merged 8 commits into from
Jan 27, 2020

Conversation

grayside
Copy link
Collaborator

@grayside grayside commented Oct 11, 2019 •
edited
Loading

Fixes #1427

@grayside grayside added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 11, 2019
@grayside grayside requested a review from fhinkel as a code owner October 11, 2019 18:55
@grayside grayside self-assigned this Oct 11, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2019
@grayside
Copy link
Collaborator Author

I triggered the manual logging test a few times in quick succession, and the
latest run-through failed. In looking it over, it appears to be an example of case 1 from the flaky test issue in #1427.

Next steps are to look at refining the log retrieval logic to see if they are sweeping too broadly or if the ordering is inconsistent.

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019
@mesmacosta
Copy link
Contributor

The iot/manager test failing seem to be related to this change:
googleapis/nodejs-iot@68a1d6e

Method name changed, but test from sample code was not updated.
client.registryPath -> client.deviceRegistryPath

@grayside grayside changed the title run/logging-manual: stabilize tests [WIP] run/logging-manual: stabilize tests Dec 12, 2019
This was referenced Dec 12, 2019
Closed
Closed
@grayside grayside merged commit c7f523a into master Jan 27, 2020
@grayside grayside deleted the run/logging-flake branch January 27, 2020 21:38
@grayside grayside removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees

@grayside grayside

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run: Manual Logging: Flaky CI tests

5 participants

@grayside @mesmacosta @fhinkel @googlebot @kokoro-team