Cloud Task + GAE + Functions Tutorial #1488

averikitsch · 2019-09-18T21:59:28Z

No description provided.

…m/nodejs-docs-samples into task-tutorial

grayside

This review covers everything up to but not including the function. As discussed in comments and in chat, I think there's some security/abuse issues that need sorting, and a number of other nits worth considering.

cloud-tasks/README.md

cloud-tasks/app/index.js

cloud-tasks/app/package.json

cloud-tasks/app/test/create_task.test.js

grant

Thanks for the PR. I've added some comments and requested changes.

Can we have more of a PR description and background to this change? Any internal docs we can link for more background?

For example:

Why do we need to use GAE and GCF together?
How does this compare to other samples?
Why was SendGrid chosen?

grant · 2019-09-19T17:28:38Z

cloud-tasks/README.md

+
+Before you can deploy the sample, you will need to do the following:
+
+1. Enable the Cloud Function and Cloud Tasks APIs in the


Please use direct links

Please ensure the product names are correct (Cloud Functions)

Suggestion

1. [Enable](https://console.cloud.google.com/flows/enableapi?apiid=cloudfunctions.googleapis.com,cloudtasks.googleapis.com) the Cloud Functions and Cloud Tasks APIs

Enable the Cloud Functions and Cloud Tasks APIs

Can I say, for example, "The Cloud Function does ..." or should I just say "The function does ..."?

cloud-tasks/README.md

cloud-tasks/function/index.js

cloud-tasks/function/test/index.test.js

…m/nodejs-docs-samples into task-tutorial

averikitsch · 2019-09-25T18:17:25Z

Thank you @grant and @grayside for the thorough reviews. Can you look over the updates?

cloud-tasks/app/static/index.css

cloud-tasks/function/index.js

cloud-tasks/function/package.json

grayside · 2019-09-30T16:57:15Z

.kokoro/cloud-tasks/common.cfg

+env_vars: {
+    key: "TRAMPOLINE_IMAGE"
+    value: "gcr.io/cloud-devrel-kokoro-resources/node:10-user"
+}


Why does cloud-tasks need a customized common.cfg? So far most products don't need one.

Every folder in .kokoro has a common.cfg file, but you are right it is a duplication of the parents.

grayside

Thank you for taking my security feedback into account, things are looking good. I gave it another careful review and while I have a number of new comments, none of them seem like merge blockers: I'm comfortable with you merging without them or taking them as useful polish feedback.

cloud-tasks/app/app.yaml

cloud-tasks/app/createTask.js

grayside · 2019-09-30T17:42:58Z

cloud-tasks/app/createTask.js

+    return response.name;
+  } catch (error) {
+    // Construct error for Stackdriver Error Reporting
+    console.error(Error(error.message));


Non-Blocking.

Did you end up confirming that console.error(error) does not work?

It would be worth comparing the output from the two commands and seeing what the difference is, it might be fixable.

I did run some more isolated tests and console.error(error) did not show up in Error Reporting.

cloud-tasks/app/index.js

cloud-tasks/function/index.js

cloud-tasks/function/test/index.test.js

…m/nodejs-docs-samples into task-tutorial

fhinkel · 2019-10-01T15:08:59Z

You can fix the lint errors with npm run lint -- --fix in the parent directory.

…m/nodejs-docs-samples into task-tutorial

averikitsch added 2 commits September 18, 2019 14:56

add samples and tests

aad4ff6

Fix kokoro typo

5b0ef75

averikitsch requested a review from fhinkel as a code owner September 18, 2019 21:59

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2019

averikitsch added 4 commits September 18, 2019 15:14

linting

5ce9b69

Merge branch 'master' into task-tutorial

9e7d19e

remove comment

6c3fedc

Merge branch 'task-tutorial' of https://github.com/GoogleCloudPlatfor…

74a300d

…m/nodejs-docs-samples into task-tutorial

averikitsch requested review from grant and grayside September 18, 2019 22:26

lint

a90062e

averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2019

averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2019

averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2019

Update service account

1d22519

grayside requested changes Sep 19, 2019

View reviewed changes

grant suggested changes Sep 19, 2019

View reviewed changes

averikitsch added 2 commits September 20, 2019 14:58

Update app

9bb9e1f

Merge branch 'master' into task-tutorial

2c2187b

averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2019

averikitsch and others added 2 commits September 23, 2019 09:42

Merge branch 'master' into task-tutorial

6477d03

Merge branch 'master' into task-tutorial

acf4a1e

fhinkel approved these changes Sep 24, 2019

View reviewed changes

averikitsch added 3 commits September 24, 2019 16:43

update tag and readme

73d7ab3

Merge branch 'task-tutorial' of https://github.com/GoogleCloudPlatfor…

95e7ac4

…m/nodejs-docs-samples into task-tutorial

remove version

f0eb573

Simplify readme

b5e103a

averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2019

grant approved these changes Sep 25, 2019

View reviewed changes

cloud-tasks/app/static/index.css Outdated Show resolved Hide resolved

cloud-tasks/function/index.js Outdated Show resolved Hide resolved

cloud-tasks/function/package.json Outdated Show resolved Hide resolved

averikitsch added 3 commits September 25, 2019 13:35

Update param comments

176961b

clean up

cadeddd

Merge branch 'master' into task-tutorial

efee1ab

grayside reviewed Sep 30, 2019

View reviewed changes

remove kokoro common file duplicate

cfbc82b

grayside approved these changes Sep 30, 2019

View reviewed changes

averikitsch added 4 commits September 30, 2019 13:28

Update comments and tests

fe94dbd

Merge branch 'task-tutorial' of https://github.com/GoogleCloudPlatfor…

4202798

…m/nodejs-docs-samples into task-tutorial

Add region tag

be4588e

g/postcard/email/

3446705

averikitsch added 4 commits October 1, 2019 12:38

Merge branch 'master' into task-tutorial

a0b74b1

re-add common file

4e8f7ea

Merge branch 'task-tutorial' of https://github.com/GoogleCloudPlatfor…

5400912

…m/nodejs-docs-samples into task-tutorial

lint

3d0f6af

averikitsch merged commit 12d9345 into master Oct 1, 2019

averikitsch deleted the task-tutorial branch October 1, 2019 20:12

This was referenced Jun 19, 2022

[Snyk] Security upgrade got from 7.1.0 to 11.8.5 ninadhatkar/nodejs-docs-samples#252

Open

[Snyk] Security upgrade got from 7.1.0 to 11.8.5 ninadhatkar/nodejs-docs-samples#253

Open

leejh3224 mentioned this pull request Jun 20, 2022

[Snyk] Security upgrade got from 9.5.0 to 11.8.5 leejh3224/nodejs-docs-samples#539

Open

ninadhatkar mentioned this pull request Jun 20, 2022

[Snyk] Security upgrade got from 7.1.0 to 11.8.5 ninadhatkar/nodejs-docs-samples#254

Open

snyk-bot mentioned this pull request Jan 10, 2023

[Snyk] Fix for 1 vulnerabilities ninadhatkar/nodejs-docs-samples#311

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cloud Task + GAE + Functions Tutorial #1488

Cloud Task + GAE + Functions Tutorial #1488

averikitsch commented Sep 18, 2019

grayside left a comment

grant left a comment

grant Sep 19, 2019

averikitsch Sep 19, 2019

averikitsch commented Sep 25, 2019

grayside Sep 30, 2019

averikitsch Sep 30, 2019

grayside left a comment

grayside Sep 30, 2019

averikitsch Sep 30, 2019

fhinkel commented Oct 1, 2019


		Before you can deploy the sample, you will need to do the following:

		1. Enable the Cloud Function and Cloud Tasks APIs in the

Cloud Task + GAE + Functions Tutorial #1488

Cloud Task + GAE + Functions Tutorial #1488

Conversation

averikitsch commented Sep 18, 2019

grayside left a comment

Choose a reason for hiding this comment

grant left a comment

Choose a reason for hiding this comment

grant Sep 19, 2019

Choose a reason for hiding this comment

Suggestion

averikitsch Sep 19, 2019

Choose a reason for hiding this comment

averikitsch commented Sep 25, 2019

grayside Sep 30, 2019

Choose a reason for hiding this comment

averikitsch Sep 30, 2019

Choose a reason for hiding this comment

grayside left a comment

Choose a reason for hiding this comment

grayside Sep 30, 2019

Choose a reason for hiding this comment

averikitsch Sep 30, 2019

Choose a reason for hiding this comment

fhinkel commented Oct 1, 2019