functions/billing: Node 8 + system tests #1361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
fhinkel
reviewed
Jun 12, 2019
|
|
||
| export GCLOUD_PROJECT=cdpe-functions-billing-test | ||
| export GCP_PROJECT=$GCLOUD_PROJECT | ||
| export GOOGLE_CLOUD_PROJECT=$GCLOUD_PROJECT |
There was a problem hiding this comment.
Is this env variable being used?
There was a problem hiding this comment.
I believe it's used elsewhere - I was mainly adding it to save us the trouble if future samples start relying on it.
fhinkel
approved these changes
Jun 12, 2019
kokoro-team
removed
the
kokoro:run
added 4 commits
June 12, 2019 14:07
ace-n
added
the
kokoro:force-run
kokoro-team
removed
kokoro:force-run
kokoro-team
removed
the
kokoro:run
added 5 commits
June 19, 2019 20:48
ace-n
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This was referenced Jan 17, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.