Skip to content

ImageMagick: use separate bucket for blurred images. #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 12, 2019
Merged

ImageMagick: use separate bucket for blurred images. #1346

merged 11 commits into from
Jun 12, 2019

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Jun 6, 2019 •
edited
Loading

@tbpg FYI

Googlers: See also cl/251939574

@ace-n ace-n requested a review from fhinkel June 6, 2019 23:12
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 6, 2019
@ace-n ace-n mentioned this pull request Jun 7, 2019
Merged
@fhinkel
Copy link
Contributor

fhinkel commented Jun 7, 2019

Linter failed :)

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 10, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 10, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 10, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 10, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@ace-n
Copy link
Contributor Author

ace-n commented Jun 12, 2019 •
edited
Loading

Merging as-is, as:
a) this contains a lint fix needed in other PRs
b) all the ImageMagick samples point to the gcf-node6-samples branch (which this PR won't change)

@ace-n ace-n merged commit 9265b1c into master Jun 12, 2019
@ace-n ace-n deleted the fix-b121041642 branch June 12, 2019 18:48
@pedroarapua pedroarapua mentioned this pull request Jul 6, 2023
Open
@dlminvestments dlminvestments mentioned this pull request Jul 6, 2023
Open
@leejh3224 leejh3224 mentioned this pull request Jul 6, 2023
Open
@dlminvestments dlminvestments mentioned this pull request Jul 6, 2023
Merged
@leejh3224 leejh3224 mentioned this pull request Jul 7, 2023
Open
@pedroarapua pedroarapua mentioned this pull request Jul 11, 2023
Open
@aqualen aqualen mentioned this pull request Jul 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ace-n @fhinkel @googlebot @kokoro-team