Skip to content

refactor(functions/sql): ava to mocha #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2019
Merged

refactor(functions/sql): ava to mocha #1240

merged 4 commits into from
Apr 4, 2019

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Apr 3, 2019

Towards #1080

refactor functions/sql ava to mocha

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2019
@AVaksman AVaksman added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 3, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 3, 2019
@AVaksman AVaksman marked this pull request as ready for review April 4, 2019 13:47
@AVaksman
Copy link
Contributor Author

AVaksman commented Apr 4, 2019

Looks like the tests didn't run for functions/sql

@AVaksman
Copy link
Contributor Author

AVaksman commented Apr 4, 2019

Opened an issue #1243

@AVaksman AVaksman added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
@fhinkel fhinkel merged commit f430af0 into GoogleCloudPlatform:master Apr 4, 2019
@dlminvestments dlminvestments mentioned this pull request Jan 10, 2023
Merged
@leejh3224 leejh3224 mentioned this pull request Jul 6, 2023
Open
@pedroarapua pedroarapua mentioned this pull request Jul 6, 2023
Open
@aqualen aqualen mentioned this pull request Nov 28, 2023
Open
@aqualen aqualen mentioned this pull request Dec 14, 2023
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Dec 15, 2023
Open
@aqualen aqualen mentioned this pull request Jan 5, 2024
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AVaksman @fhinkel @googlebot @kokoro-team