Conversation
|
This (cautiously) LGTM. I really would've preferred the following set of commits in this PR:
This changeset is difficult to review with accuracy because you made several small, non-style changes. |
Current coverage is 77.94%@@ master #116 diff @@
==========================================
Files 35 35
Lines 1552 1528 -24
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1234 1191 -43
- Misses 318 337 +19
Partials 0 0
|
kweinmeister
pushed a commit
that referenced
this pull request
Nov 7, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.1](googleapis/nodejs-org-policy@v2.0.0...v2.0.1) (2022-06-30) ### Bug Fixes * **docs:** describe fallback rest option ([#115](googleapis/nodejs-org-policy#115)) ([c54a19b](googleapis/nodejs-org-policy@c54a19b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kweinmeister
pushed a commit
that referenced
this pull request
Nov 8, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.1](googleapis/nodejs-org-policy@v2.0.0...v2.0.1) (2022-06-30) ### Bug Fixes * **docs:** describe fallback rest option ([#115](googleapis/nodejs-org-policy#115)) ([c54a19b](googleapis/nodejs-org-policy@c54a19b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kweinmeister
pushed a commit
that referenced
this pull request
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.