Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes speech-to-speech function compatible with Firebase. #1113

Merged
merged 5 commits into from
Jan 30, 2019
Merged

Makes speech-to-speech function compatible with Firebase. #1113

merged 5 commits into from
Jan 30, 2019

Conversation

ricalo
Copy link
Member

@ricalo ricalo commented Jan 29, 2019

To make the speech-to-speech function compatible with Cloud Functions for Firebase, the following changes are included in this commit:

  • Adds .firebaserc file.
  • Adds firebase.json file.
  • Imports firebase-functions library.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2019
fhinkel
fhinkel approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 29, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 29, 2019
@ricalo
Copy link
Member Author

ricalo commented Jan 29, 2019

Thanks, @fhinkel
All the required tests are passing. Let me know if there's something else I need to do to get this PR merged.

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 30, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 30, 2019
@fhinkel fhinkel merged commit d445ff5 into GoogleCloudPlatform:master Jan 30, 2019
@ricalo ricalo deleted the feature/opt-fire branch January 30, 2019 16:37
@snyk-bot snyk-bot mentioned this pull request Sep 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ricalo @fhinkel @googlebot @kokoro-team