Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cloudsql-mysql.cfg #1111

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Update cloudsql-mysql.cfg #1111

merged 2 commits into from
Jan 29, 2019

Conversation

kurtisvg
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Jan 29, 2019 •
edited
Loading

Thanks! the tests don't quite work yet. Could you have a look. I just pushed a fix for the linter error.

@fhinkel
Copy link
Contributor

fhinkel commented Jan 29, 2019

Merging this, but there are other problems with the test.

@fhinkel fhinkel merged commit c5056b3 into master Jan 29, 2019
@fhinkel fhinkel deleted the kurtisvg-patch-1 branch January 29, 2019 18:51
@kurtisvg
Copy link
Contributor Author

I was working on fixing the tests themselves. I've opened #1114.

@snyk-bot snyk-bot mentioned this pull request Sep 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurtisvg @fhinkel @googlebot