Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger sample only activates when GCLOUD_PROJECT is defined #237

Closed
ofrobots opened this issue Oct 13, 2016 · 0 comments
Closed

Debugger sample only activates when GCLOUD_PROJECT is defined #237

ofrobots opened this issue Oct 13, 2016 · 0 comments
Assignees
@jmdobry
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@ofrobots
Copy link
Contributor

ofrobots commented Oct 13, 2016 •
edited
Loading

nodejs-docs-samples/debugger/app.js

Line 19 in ba151d5

if (process.env.GCLOUD_PROJECT) { 

if (process.env.GCLOUD_PROJECT) {
  require('@google/cloud-debug');
}

What is the rationale for checking for GCLOUD_PROJECT being defined? On GCE and GKE, this env. var. is not going to be defined unless the customer explicitly defines it.
@jmdobry jmdobry closed this as completed in 145831c Feb 8, 2017
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
NimJay pushed a commit that referenced this issue Nov 11, 2022
@release-please @bcoe
chore: release 1.5.3 (#237)
ce27837
@NimJay NimJay mentioned this issue Nov 11, 2022
Merged
ace-n pushed a commit that referenced this issue Nov 11, 2022
@release-please
chore: release 1.5.3 (#237)
0a242af
ace-n pushed a commit that referenced this issue Nov 17, 2022
@JustinBeckwith
refactor: use execSync for tests (#237)
f4bcbae
@ace-n ace-n mentioned this issue Nov 17, 2022
Merged
unforced pushed a commit that referenced this issue Nov 17, 2022
@release-please
chore(main): release 4.0.1 (#237)
5e5878d 
🤖 I have created a release *beep* *boop*
---


## [4.0.1](googleapis/nodejs-service-directory@v4.0.0...v4.0.1) (2022-06-30)


### Bug Fixes

* **docs:** describe fallback rest option ([#236](googleapis/nodejs-service-directory#236)) ([f72541a](googleapis/nodejs-service-directory@f72541a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@unforced unforced mentioned this issue Nov 17, 2022
Merged
unforced pushed a commit that referenced this issue Nov 17, 2022
@release-please
chore(main): release 4.0.1 (#237)
495cf86 
🤖 I have created a release *beep* *boop*
---


## [4.0.1](googleapis/nodejs-service-directory@v4.0.0...v4.0.1) (2022-06-30)


### Bug Fixes

* **docs:** describe fallback rest option ([#236](googleapis/nodejs-service-directory#236)) ([f72541a](googleapis/nodejs-service-directory@f72541a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this issue Nov 17, 2022
@JustinBeckwith
refactor: use execSync for tests (#237)
fe711fd
ahrarmonsur pushed a commit that referenced this issue Nov 17, 2022
@release-please @ahrarmonsur
chore(main): release 4.0.1 (#237)
78cf1a6 
🤖 I have created a release *beep* *boop*
---


## [4.0.1](googleapis/nodejs-service-directory@v4.0.0...v4.0.1) (2022-06-30)


### Bug Fixes

* **docs:** describe fallback rest option ([#236](googleapis/nodejs-service-directory#236)) ([f72541a](googleapis/nodejs-service-directory@f72541a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this issue Nov 17, 2022
@JustinBeckwith
refactor: use execSync for tests (#237)
167937a
ace-n pushed a commit that referenced this issue Nov 17, 2022
@JustinBeckwith
refactor: use execSync for tests (#237)
54a05b4
ace-n pushed a commit that referenced this issue Nov 17, 2022
@JustinBeckwith
refactor: use execSync for tests (#237)
c90ed71
Shabirmean pushed a commit that referenced this issue Feb 16, 2023
@JustinBeckwith
refactor: modernize the sample tests (#237)
7b9c68f
@Shabirmean Shabirmean mentioned this issue Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmdobry jmdobry

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ofrobots @jmdobry @yoshi-automation