-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Labels
🚨This issue needs some love.This issue needs some love.api: cloudfunctionsIssues related to the Cloud Run functions API.Issues related to the Cloud Run functions API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.samplesIssues that are directly related to samples.Issues that are directly related to samples.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Two tests have this same failure state, which prevents effective triage.
- The tests need to be fixed
- The test needs to surface the underlying error.
Currently blocking merge on #1515
functions/billing tests
notifies Slack
functions_billing_slack
✓ should notify Slack when budget is exceeded (868ms)
disables billing
functions_billing_stop
(node:61) UnhandledPromiseRejectionWarning: ChildProcessError: Command failed: functions-framework --target=notifySlack --signature-type=event --port 8080
`functions-framework --target=notifySlack --signature-type=event --port 8080` (exited with error code null)
at callback (/tmpfs/src/github/nodejs-docs-samples/functions/billing/node_modules/child-process-promise/lib/index.js:33:27)
at ChildProcess.exithandler (child_process.js:288:5)
at emitTwo (events.js:126:13)
at ChildProcess.emit (events.js:214:7)
at maybeClose (internal/child_process.js:915:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
(node:61) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:61) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
1) should disable billing when budget is exceeded
Metadata
Metadata
Assignees
Labels
🚨This issue needs some love.This issue needs some love.api: cloudfunctionsIssues related to the Cloud Run functions API.Issues related to the Cloud Run functions API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.samplesIssues that are directly related to samples.Issues that are directly related to samples.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.