Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions/scheduleinstance does not run as nodejs8 or nodejs10 #1272

Closed
nbards opened this issue May 9, 2019 · 2 comments
Closed

functions/scheduleinstance does not run as nodejs8 or nodejs10 #1272

nbards opened this issue May 9, 2019 · 2 comments
Assignees

Comments

@nbards
Copy link

nbards commented May 9, 2019

When following through the tutorial about Cloud Scheduler [https://cloud.google.com/scheduler/docs/start-and-stop-compute-engine-instances-on-a-schedule#set_up_the_functions_with] and deploying the function as node.js 6 a warning is thrown about the deprecation of node.js 6 and reccomends node.js 8 or node.js 10.

the package.json file states

  "engines": {
"node": ">=8"

but deploying the function as nodejs8 gives this error

 "TypeError: callback is not a function
    at exports.stopInstancePubSub (/srv/index.js:105:5)
    at /worker/worker.js:825:24
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:229:7)"  

and nodejs10 gives this one

 "TypeError: callback is not a function
    at exports.stopInstancePubSub (/srv/functions/index.js:105:5)
    at Promise.resolve.then (/srv/node_modules/@google-cloud/functions-framework/build/src/invoker.js:330:28)
    at process._tickCallback (internal/process/next_tick.js:68:7)"  
@fhinkel
Copy link
Contributor

fhinkel commented May 13, 2019

@ace-n can you have a look, thanks!

@ace-n
Copy link
Contributor

ace-n commented May 13, 2019

Fixed in #1273 - closing this issue in favor of that PR.

@ace-n ace-n closed this as completed May 13, 2019
This was referenced Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants