* Refactored Pub/Sub samples into nice command-line programs, like the new Cloud Storage samples (#164)

* Brought Pub/Sub samples code coverage up to 98.66%

Author: jmdobry

vision/samples/system-test/faceDetection.test.js

@@ -55,7 +55,7 @@ describe('vision:faceDetection', function () {
       outputFile,
       MockCanvas,
       function (err, faces) {
-        assert(!err);
+        assert.ifError(err);
         assert(faces.length === 1);
         var image = fs.readFileSync(outputFile);
         assert(image.toString('utf8') === 'testfoobar');

vision/samples/system-test/labelDetection.test.js

@@ -22,7 +22,7 @@ describe('vision:labelDetection', function () {
     labelDetectionSample.main(
       inputFile,
       function (err, labels) {
-        assert(!err);
+        assert.ifError(err);
         assert(labels.length > 0);
         assert(console.log.calledWith('Found label: cat for ' + inputFile));
         done();

vision/samples/system-test/landmarkDetection.test.js

@@ -19,7 +19,7 @@ var inputFile = 'https://cloud-samples-tests.storage.googleapis.com/vision/water
 describe('vision:landmarkDetection', function () {
   it('should detect landmarks', function (done) {
     landmarkDetectionSample.main(inputFile, function (err, landmarks) {
-      assert(!err);
+      assert.ifError(err);
       assert(landmarks.length > 0);
       assert(console.log.calledWith('Found landmark: Taitung, Famous Places "up the water flow" marker for ' + inputFile));
       done();

vision/samples/system-test/textDetection.test.js

@@ -20,10 +20,10 @@ var textDetectionSample = require('../textDetection');
 describe('vision:textDetection', function () {
   it('should detect texts', function (done) {
     textDetectionSample.main(inputDir, function (err, textResponse) {
-      assert(!err);
+      assert.ifError(err);
       assert(Object.keys(textResponse).length > 0);
       textDetectionSample.lookup(['the', 'sunbeams', 'in'], function (err, hits) {
-        assert(!err);
+        assert.ifError(err);
         assert(hits.length > 0);
         assert(hits[0].length > 0);
         done();