Skip to content

Commit 46d49b5

Browse files
Ace Nassrifhinkel
authored andcommitted
Fix HTTP package being deprecated (#1524)
1 parent 98713dc commit 46d49b5

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

functions/concepts/index.js

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -114,24 +114,17 @@ exports.listFiles = (req, res) => {
114114
// [END functions_concepts_filesystem]
115115

116116
// [START functions_concepts_requests]
117-
const request = require('request');
117+
const fetch = require('node-fetch');
118118

119119
/**
120120
* HTTP Cloud Function that makes an HTTP request
121121
*
122122
* @param {Object} req Cloud Function request context.
123123
* @param {Object} res Cloud Function response context.
124124
*/
125-
exports.makeRequest = (req, res) => {
126-
// The URL to send the request to
127-
const url = 'https://example.com';
128-
129-
request(url, (err, response) => {
130-
if (!err && response.statusCode === 200) {
131-
res.sendStatus(200);
132-
} else {
133-
res.sendStatus(500);
134-
}
135-
});
125+
exports.makeRequest = async (req, res) => {
126+
const url = 'https://example.com'; // URL to send the request to
127+
const externalRes = await fetch(url);
128+
res.sendStatus(externalRes.ok ? 200 : 500);
136129
};
137130
// [END functions_concepts_requests]

functions/concepts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"node": ">=8.0.0"
1313
},
1414
"dependencies": {
15-
"request": "^2.85.0"
15+
"node-fetch": "^2.6.0"
1616
},
1717
"devDependencies": {
1818
"@google-cloud/nodejs-repo-tools": "^3.3.0",

0 commit comments

Comments
 (0)