Skip to content

Commit 4330fae

Browse files
authored
docs: update notification samples to v1 (#236)
Notification feature work has been merged into v1, so we need to update the samples to match the updated version.
1 parent ea95500 commit 4330fae

File tree

7 files changed

+11
-27
lines changed

7 files changed

+11
-27
lines changed

security-center/snippets/system-test/v1p1beta1/notifications.test.js renamed to security-center/snippets/system-test/v1/notifications.test.js

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@
1414

1515
'use strict';
1616

17-
const {
18-
SecurityCenterClient,
19-
} = require('@google-cloud/security-center').v1p1beta1;
17+
const {SecurityCenterClient} = require('@google-cloud/security-center');
2018
const uuidv1 = require('uuid').v1;
2119
const {assert} = require('chai');
2220
const {describe, it, before, after} = require('mocha');
@@ -44,7 +42,6 @@ describe('Client with Notifications', async () => {
4442
notificationConfig: {
4543
description: 'Sample config for node.js',
4644
pubsubTopic: pubsubTopic,
47-
eventType: 'FINDING',
4845
streamingConfig: {filter: 'state = "ACTIVE"'},
4946
},
5047
});
@@ -71,7 +68,7 @@ describe('Client with Notifications', async () => {
7168

7269
it('client can create config', () => {
7370
const output = exec(
74-
`node v1p1beta1/createNotificationConfig.js ${organizationId} ${createConfig} ${pubsubTopic}`
71+
`node v1/createNotificationConfig.js ${organizationId} ${createConfig} ${pubsubTopic}`
7572
);
7673
assert.include(output, createConfig);
7774
assert.match(output, /Notification config creation succeeded/);
@@ -80,33 +77,31 @@ describe('Client with Notifications', async () => {
8077

8178
it('client can delete config', () => {
8279
const output = exec(
83-
`node v1p1beta1/deleteNotificationConfig.js ${organizationId} ${deleteConfig}`
80+
`node v1/deleteNotificationConfig.js ${organizationId} ${deleteConfig}`
8481
);
8582
assert.include(output, 'Notification config deleted');
8683
assert.notMatch(output, /undefined/);
8784
});
8885

8986
it('client can get config', () => {
9087
const output = exec(
91-
`node v1p1beta1/getNotificationConfig.js ${organizationId} ${getConfig}`
88+
`node v1/getNotificationConfig.js ${organizationId} ${getConfig}`
9289
);
9390
assert.include(output, getConfig);
9491
assert.match(output, /Notification config/);
9592
assert.notMatch(output, /undefined/);
9693
});
9794

9895
it('client can list configs', () => {
99-
const output = exec(
100-
`node v1p1beta1/listNotificationConfigs.js ${organizationId}`
101-
);
96+
const output = exec(`node v1/listNotificationConfigs.js ${organizationId}`);
10297
assert.include(output, listConfig);
10398
assert.match(output, /Received Notification configs/);
10499
assert.notMatch(output, /undefined/);
105100
});
106101

107102
it('client can update configs', () => {
108103
const output = exec(
109-
`node v1p1beta1/updateNotificationConfig.js ${organizationId} ${updateConfig} ${pubsubTopic}`
104+
`node v1/updateNotificationConfig.js ${organizationId} ${updateConfig} ${pubsubTopic}`
110105
);
111106
assert.include(output, updateConfig);
112107
assert.match(output, /notification config update succeeded/);

security-center/snippets/v1p1beta1/createNotificationConfig.js renamed to security-center/snippets/v1/createNotificationConfig.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ function main(
2020
) {
2121
// [START scc_create_notification_config]
2222
// npm install @google-cloud/security-center/
23-
const {
24-
SecurityCenterClient,
25-
} = require('@google-cloud/security-center').v1p1beta1;
23+
const {SecurityCenterClient} = require('@google-cloud/security-center');
2624

2725
const client = new SecurityCenterClient();
2826

@@ -40,7 +38,6 @@ function main(
4038
notificationConfig: {
4139
description: 'Sample config for node.js',
4240
pubsubTopic: pubsubTopic,
43-
eventType: 'FINDING',
4441
streamingConfig: {filter: 'state = "ACTIVE"'},
4542
},
4643
});

security-center/snippets/v1p1beta1/deleteNotificationConfig.js renamed to security-center/snippets/v1/deleteNotificationConfig.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@
1616
function main(organizationId = 'your-org-id', configId = 'your-config-id') {
1717
// [START scc_delete_notification_config]
1818
// npm install @google-cloud/security-center/
19-
const {
20-
SecurityCenterClient,
21-
} = require('@google-cloud/security-center').v1p1beta1;
19+
const {SecurityCenterClient} = require('@google-cloud/security-center');
2220

2321
const client = new SecurityCenterClient();
2422

security-center/snippets/v1p1beta1/getNotificationConfig.js renamed to security-center/snippets/v1/getNotificationConfig.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@
1616
function main(organizationId = 'your-org-id', configId = 'your-config-id') {
1717
// [START scc_get_notification_configs]
1818
// npm install @google-cloud/security-center/
19-
const {
20-
SecurityCenterClient,
21-
} = require('@google-cloud/security-center').v1p1beta1;
19+
const {SecurityCenterClient} = require('@google-cloud/security-center');
2220

2321
const client = new SecurityCenterClient();
2422

security-center/snippets/v1p1beta1/listNotificationConfigs.js renamed to security-center/snippets/v1/listNotificationConfigs.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@
1616
function main(organizationId = 'your-org-id') {
1717
// [START scc_list_notification_configs]
1818
// npm install @google-cloud/security-center/
19-
const {
20-
SecurityCenterClient,
21-
} = require('@google-cloud/security-center').v1p1beta1;
19+
const {SecurityCenterClient} = require('@google-cloud/security-center');
2220

2321
const client = new SecurityCenterClient();
2422

File renamed without changes.

security-center/snippets/v1p1beta1/updateNotificationConfig.js renamed to security-center/snippets/v1/updateNotificationConfig.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ function main(
2020
) {
2121
// [START scc_update_notification_config]
2222
// npm install @google-cloud/security-center/
23-
const {
24-
SecurityCenterClient,
25-
} = require('@google-cloud/security-center').v1p1beta1;
23+
const {SecurityCenterClient} = require('@google-cloud/security-center');
2624

2725
const client = new SecurityCenterClient();
2826

0 commit comments

Comments
 (0)