-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resource v1 SCC Findings Export to BQ Project Config #11595
Add Resource v1 SCC Findings Export to BQ Project Config #11595
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@NickElliot do you mind grabbing this review? I've been spread a bit thin recently. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 15 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, mostly LGTM but needs a couple formatting tweaks, and could you provide a debug log of running the new tests locally? Thanks!
Edit scratch that, saw the handwritten test wasnt skipped, thought they both were for a moment
project: :PROJECT_NAME | ||
ignore_read_extra: | ||
- 'project' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
dataset = google_bigquery_dataset.default.id | ||
description = "SCC Findings Big Query Export Update" | ||
filter = "state=\"ACTIVE\" AND NOT mute=\"MUTED\"" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
The supported operators are: | ||
|
||
* = for all value types. | ||
* >, <, >=, <= for integer values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* >, <, >=, <= for integer values. | |
* \>, <, >=, <= for integer values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 15 Click here to see the affected service packages
View the build log |
# limitations under the License. | ||
|
||
--- !ruby/object:Api::Resource | ||
name: 'ProjectSccBigQueryExports' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by comment: These should be singular, not plural. The file name will also need to change.
name: 'ProjectSccBigQueryExports' | |
name: 'ProjectSccBigQueryExport' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now other than the change @melinath requested. Update when you get a chance, thanks!
…roject-level-config
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 15 Click here to see the affected service packages
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 15 Click here to see the affected service packages
View the build log |
@NickElliot my change request has been addressed, back to you. |
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related to http://b/356159589.
Bug Description: hashicorp/terraform-provider-google#18848
Adding new template for V1 SCC Findings Exports to Big Query Project Config
https://cloud.google.com/security-command-center/docs/reference/rest/v1/projects.bigQueryExports
Release Note Template for Downstream PRs (will be copied)