Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource v1 SCC Findings Export to BQ Project Config #11595

Conversation

vijaykanthm
Copy link
Contributor

@vijaykanthm vijaykanthm commented Aug 30, 2024

Related to http://b/356159589.

Bug Description: hashicorp/terraform-provider-google#18848

Adding new template for V1 SCC Findings Exports to Big Query Project Config
https://cloud.google.com/security-command-center/docs/reference/rest/v1/projects.bigQueryExports

Release Note Template for Downstream PRs (will be copied)

`google_scc_project_scc_big_query_export`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from rileykarson August 30, 2024 18:24
@rileykarson rileykarson requested review from NickElliot and removed request for rileykarson August 30, 2024 18:27
@rileykarson
Copy link
Member

@NickElliot do you mind grabbing this review? I've been spread a bit thin recently.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 951 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 951 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securitycenter

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterProjectBigQueryExportConfig_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterProjectBigQueryExportConfig_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Copy link

github-actions bot commented Sep 4, 2024

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, mostly LGTM but needs a couple formatting tweaks, and could you provide a debug log of running the new tests locally? Thanks!

Edit scratch that, saw the handwritten test wasnt skipped, thought they both were for a moment

project: :PROJECT_NAME
ignore_read_extra:
- 'project'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

dataset = google_bigquery_dataset.default.id
description = "SCC Findings Big Query Export Update"
filter = "state=\"ACTIVE\" AND NOT mute=\"MUTED\""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

The supported operators are:

* = for all value types.
* >, <, >=, <= for integer values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* >, <, >=, <= for integer values.
* \>, <, >=, <= for integer values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

@github-actions github-actions bot requested a review from NickElliot September 4, 2024 20:59
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 950 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 950 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenter

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

# limitations under the License.

--- !ruby/object:Api::Resource
name: 'ProjectSccBigQueryExports'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by comment: These should be singular, not plural. The file name will also need to change.

Suggested change
name: 'ProjectSccBigQueryExports'
name: 'ProjectSccBigQueryExport'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now other than the change @melinath requested. Update when you get a chance, thanks!

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 950 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 950 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenter

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 950 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 950 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenter

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@melinath melinath removed their request for review September 11, 2024 22:20
@melinath melinath dismissed their stale review September 11, 2024 22:20

Stale review

@melinath
Copy link
Member

@NickElliot my change request has been addressed, back to you.

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants