Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scope-defining fields on ConfigConnector #2602

Open
3 tasks done
dhoeric-wu opened this issue Sep 1, 2024 · 0 comments
Open
3 tasks done

Support scope-defining fields on ConfigConnector #2602

dhoeric-wu opened this issue Sep 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dhoeric-wu
Copy link

dhoeric-wu commented Sep 1, 2024

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

Be able to define the project scope on the ConfigConnector custom resource.

It is similar to annotation on resource or namespace, but allow to define on the ConfigConnector level.

Additional information

https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/v1.121.0/operator/config/crd/bases/core.cnrm.cloud.google.com_configconnectors.yaml

Importance

Current Situation

Currently, the scope-defining field requires specifying the project ID on either the resource or namespace level.

Proposed Improvement

As a cluster operator, it would be beneficial to specify the project scope directly on the ConfigConnector resource. This approach would eliminate the need to duplicate the project ID across multiple namespaces or resources.

Potential Implementation

A possible modification to the ConfigConnector spec could look like this:

apiVersion: core.cnrm.cloud.google.com/v1beta1
kind: ConfigConnector
metadata:
  name: configconnector.core.cnrm.cloud.google.com
spec:
  projectId: xxxx  # New field
  ...

Extended Application

This concept of centralized scope definition could also be applied to other scopes, such as folder or organization levels.

@dhoeric-wu dhoeric-wu added the enhancement New feature or request label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant