fix: Update .gitignore so that .jar file isn't included #7505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #7503 was raised about including maven-wrapper.jar. @ludoch helpfully pointed out https://maven.apache.org/wrapper/; effectively we can remove the .jar, it makes using the sample a little more difficult, but with the rule to not include binary artifacts into our source code, seems like the right thing to do
product-auto-label
bot
added
the
samples
iennae
changed the title
averikitsch
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7503 was raised about including maven-wrapper.jar. @ludoch helpfully pointed out https://maven.apache.org/wrapper/; effectively we can remove the .jar, it makes using the sample a little more difficult, but with the rule to not include binary artifacts into our source code, seems like the right thing to do
@averikitsch if you can take a look