Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Java snippets for creating, listing, and deleting queues #3176

Merged

Conversation

aarjo
Copy link
Contributor

@aarjo aarjo commented Jun 16, 2020

Environment Variables need to be set:

  • GOOGLE_CLOUD_PROJECT to the project id

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2020
@aarjo aarjo marked this pull request as ready for review June 18, 2020 16:19
@aarjo aarjo requested a review from a team June 18, 2020 16:19
@lesv lesv added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 18, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 18, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@lesv lesv added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jun 18, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2020
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to update the README.md to mention these?

Also, I don't see any RegionTags -- You'll eventually want to add those.

@lesv lesv added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 18, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 18, 2020
@aarjo
Copy link
Contributor Author

aarjo commented Jun 18, 2020

Do you need to update the README.md to mention these?

Also, I don't see any RegionTags -- You'll eventually want to add those.

I'll update the README, and I believe there are region tags starting above the imports, no?

Also, what would be the best way to resolve the static analysis error? Making the snippet methods private means they can't be called in the testing classes.

@lesv
Copy link
Contributor

lesv commented Jun 18, 2020

It's not required (or sometimes possible) to get all the static analysis errors. You can google them spotBugs to see if any of them are easy to fix. It's to get you to think about writing better code.

Yea - I just checked two files and didn't see them in the PR, but they were there. Just tell me when you'd like me to merge.

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@lesv lesv merged commit ef3bafd into GoogleCloudPlatform:master Jun 21, 2020
averikitsch pushed a commit that referenced this pull request Oct 27, 2022
…#3176)

* add Java snippets for creating, listing, and deleting queues

* update licenses

* styling fixes for lint

* fix test comments and remove oldout

* have createhttptask use env var

* Change System.getProperty to System.getenv and require LOCATION_ID environment variable as well

* specify exception type in throws

* add main methods and remove javadoc style comments to adhere with style guide
averikitsch pushed a commit that referenced this pull request Nov 1, 2022
…#3176)

* add Java snippets for creating, listing, and deleting queues

* update licenses

* styling fixes for lint

* fix test comments and remove oldout

* have createhttptask use env var

* Change System.getProperty to System.getenv and require LOCATION_ID environment variable as well

* specify exception type in throws

* add main methods and remove javadoc style comments to adhere with style guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants