Skip to content

Conversation

@Strykrol
Copy link
Contributor

Tests are currently unaltered, as the tests have variable dependencies. An example being the listContexts function stores a count into a contexts variable, which is then used to verify deleteContext functions as expected.

If I can get help refactoring test files that would be great. Otherwise, I will take a stab at them later this week.

@Strykrol Strykrol requested a review from a team March 24, 2020 23:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2020
@lesv lesv added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 24, 2020
@lesv
Copy link
Contributor

lesv commented Mar 24, 2020

A lot of ML samples need to be very loosely tested as the technology often changes underneath us.
I put a "do not merge" tag until you get the tests back.

@lesv
Copy link
Contributor

lesv commented Mar 25, 2020

Apparently I wasn't thinking when I commented yesterday.

@lesv lesv added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 25, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2020
@nnegrey
Copy link
Contributor

nnegrey commented Apr 1, 2020

Assigning to myself to get the tests updated for these.

@nnegrey nnegrey self-assigned this Apr 1, 2020
@lesv lesv added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 1, 2020
@nnegrey
Copy link
Contributor

nnegrey commented Apr 3, 2020

@Strykrol should there be more deletions than just the list methods?
I'm gonna break up the tests into individual files.

@Strykrol
Copy link
Contributor Author

Strykrol commented Apr 3, 2020

@nnegrey - Yes, I will add those momentarily and update the PR.

@Strykrol Strykrol changed the title remove unused list_* samples dialogflow: remove unused samples and tests Apr 3, 2020
@Strykrol
Copy link
Contributor Author

Strykrol commented Apr 3, 2020

@nnegrey - Added the remaining deletions (which generally deleted their entire containing files).

You're good to go with test refactoring, thank you for helping out.

@nnegrey nnegrey added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 3, 2020
@nnegrey
Copy link
Contributor

nnegrey commented Apr 3, 2020

@Strykrol, um mind pulling down the latest changes then just merging in master to the branch?

I was trying to do it, but just ended up creating a new branch on here. https://github.com/GoogleCloudPlatform/java-docs-samples/tree/Strykrol-snippetCleanup

Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass.

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2020
@nnegrey nnegrey added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2020
@nnegrey
Copy link
Contributor

nnegrey commented Apr 9, 2020

Closing, something got lost in this PR and the tests are not finishing.
I've opened this one #2602 that I can directly edit.

@nnegrey nnegrey closed this Apr 9, 2020
@Strykrol Strykrol deleted the snippetCleanup branch April 23, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants