-
Notifications
You must be signed in to change notification settings - Fork 2.9k
dialogflow: remove unused samples and tests #2483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A lot of ML samples need to be very loosely tested as the technology often changes underneath us. |
|
Apparently I wasn't thinking when I commented yesterday. |
|
Assigning to myself to get the tests updated for these. |
|
@Strykrol should there be more deletions than just the list methods? |
|
@nnegrey - Yes, I will add those momentarily and update the PR. |
…s-samples into snippetCleanup merge upstream changes
|
@nnegrey - Added the remaining deletions (which generally deleted their entire containing files). You're good to go with test refactoring, thank you for helping out. |
|
@Strykrol, um mind pulling down the latest changes then just merging in master to the branch? I was trying to do it, but just ended up creating a new branch on here. https://github.com/GoogleCloudPlatform/java-docs-samples/tree/Strykrol-snippetCleanup |
gguuss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when tests pass.
|
Closing, something got lost in this PR and the tests are not finishing. |
Tests are currently unaltered, as the tests have variable dependencies. An example being the
listContextsfunction stores a count into acontextsvariable, which is then used to verifydeleteContextfunctions as expected.If I can get help refactoring test files that would be great. Otherwise, I will take a stab at them later this week.