Use test endpoint for datalabeling integration tests.#1803
Use test endpoint for datalabeling integration tests.#1803dzlier-gcp merged 7 commits intoGoogleCloudPlatform:masterfrom
Conversation
googlebot
added
the
cla: yes
averikitsch
left a comment
averikitsch
left a comment
There was a problem hiding this comment.
Since there is no ReadMe for this sample, do the docs mention the new environment variable "DATALABELING_ENDPOINT"?
...beling/beta/cloud-client/src/main/java/com/example/datalabeling/CreateAnnotationSpecSet.java
Outdated
Show resolved
Hide resolved
| endpoint = DataLabelingServiceSettings.getDefaultEndpoint(); | ||
| } | ||
|
|
||
| try (DataLabelingServiceClient dataLabelingServiceClient = |
There was a problem hiding this comment.
Please add comments to each file, that this is unnecessary for users to do or something to that effect.
There was a problem hiding this comment.
+1. We should also add a comment why this is necessary for these snippets, and try to hide this portion from being staged in the documentation.
There was a problem hiding this comment.
nit: It would be nice to still add a comment here (doesn't need to be in the staged version) to explain the extra code.
|
Tests are not passing now that the variable typo was fixed. |
| endpoint = DataLabelingServiceSettings.getDefaultEndpoint(); | ||
| } | ||
|
|
||
| try (DataLabelingServiceClient dataLabelingServiceClient = |
There was a problem hiding this comment.
+1. We should also add a comment why this is necessary for these snippets, and try to hide this portion from being staged in the documentation.
dzlier-gcp
force-pushed
the
datalabeling
branch
from
c3bc592 to
681182f
Compare
kurtisvg
force-pushed
the
datalabeling
branch
from
681182f to
5a3ce71
Compare
|
Justin suggested talking to Jeff Ching about moving this sample into the Datalabeling repo so that the tests are only triggered when an actual change to datalabeling goes through, instead of changing the endpoint we're targeting, so I'm going to check with him before submitting. |
|
@dzlier-gcp Perhaps we should submit this now so that the current integration tests stop, and then move it in a different PR |
* Use test endpoint for datalabeling integration tests. * Fix formatting * Fix typo * Fix formatting * Add quotes to variable * Add execeptions to method signitures.
* Use test endpoint for datalabeling integration tests. * Fix formatting * Fix typo * Fix formatting * Add quotes to variable * Add execeptions to method signitures.
4 participants
No description provided.