-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix listening on port 8080 Warning #1511
Conversation
Uses the PORT environment variable when is present, otherwise sets 8080.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this change is warranted. I think AppEngine always wants port 8080?
@averikitsch - thoughts?
...a11/appengine-simple-jetty-main/src/main/java/com/example/appengine/demo/jettymain/Main.java
Outdated
Show resolved
Hide resolved
@kurtisvg I did this to prevent this warning in the console logs viewer :
And I will update the code, following your recommendations. |
@kurtisvg this must be a new warning. The app is suppose to be listening to port 8080. (This error sounds more like a Cloud Run error). I will check in the the GAE team. |
@averikitsch Updated! |
...a11/appengine-simple-jetty-main/src/main/java/com/example/appengine/demo/jettymain/Main.java
Outdated
Show resolved
Hide resolved
…/example/appengine/demo/jettymain/Main.java Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [3.6.7](googleapis/java-dlp@v3.6.6...v3.6.7) (2022-08-05) ### Documentation * **owlbot-java:** explaining why not using formatter in pom.xml ([#1511](https://github.com/googleapis/java-dlp/issues/1511)) ([#945](googleapis/java-dlp#945)) ([ab8d91f](googleapis/java-dlp@ab8d91f)), closes [#1502](https://github.com/googleapis/java-dlp/issues/1502) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
When the application is deployed with hard-coded port configuration, appear the Warning:
'App is listening on port 8080, it should instead listen on the port defined by the PORT environment variable.'
This patch look for the PORT environment variable, otherwise set 8080.