-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Updated Infinite streaming sample #1422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
89ff77a
5563759
0aa1b2e
55dd1c9
10090b7
a86baa5
401c83e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -113,22 +113,22 @@ public void testStreamRecognize() throws Exception { | |
@Test | ||
public void testAutoPunctuation() throws Exception { | ||
Recognize.transcribeFileWithAutomaticPunctuation(audioFileName); | ||
String got = bout.toString(); | ||
assertThat(got).contains("How old is the Brooklyn Bridge?"); | ||
String got = bout.toString().toLowerCase(); | ||
assertThat(got).contains("how old is the brooklyn bridge"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @blechdom Hey, sorry just seeing this, can you revert these test changes? These are testing the Auto Punctuation API and should be verifying capitalization and symbols. Otherwise, we need to notify the product team of an issue on their backend. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @nnegrey Sorry, that was my fault. I pushed the changes to unblock the tests. Is it just the Auto Punctuation API you want reverted? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yea, are they failing? I can go check with the product team if they made a change to something. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Filed a bug, if they respond and fix, I can revert the samples to the old state and leave them as is for now. Thanks! |
||
} | ||
|
||
@Test | ||
public void testGcsAutoPunctuation() throws Exception { | ||
Recognize.transcribeGcsWithAutomaticPunctuation(gcsAudioPath); | ||
String got = bout.toString(); | ||
assertThat(got).contains("How old is the Brooklyn Bridge?"); | ||
String got = bout.toString().toLowerCase(); | ||
assertThat(got).contains("how old is the brooklyn bridge"); | ||
} | ||
|
||
@Test | ||
public void testStreamAutoPunctuation() throws Exception { | ||
Recognize.streamingTranscribeWithAutomaticPunctuation(audioFileName); | ||
String got = bout.toString(); | ||
assertThat(got).contains("How old is the Brooklyn Bridge?"); | ||
String got = bout.toString().toLowerCase(); | ||
assertThat(got).contains("how old is the brooklyn bridge"); | ||
} | ||
|
||
@Test | ||
|
Uh oh!
There was an error while loading. Please reload this page.